Re: [RFC] building postgres with meson -v

2022-08-05 Thread Andres Freund
Hi, On 2021-10-31 16:24:48 -0700, Andres Freund wrote: > - support for building docs. > I couldn't get dbtoepub work in a vpath style build, so I changed that > to also use pandoc. No idea if anybody uses the epub rules? combing through various FIXMEs in the meson patch I started to look into

Re: [RFC] building postgres with meson -v

2021-11-10 Thread Andres Freund
Hi, On 2021-11-10 11:07:02 +0100, Peter Eisentraut wrote: > On 01.11.21 00:24, Andres Freund wrote: > > Hi, > > > > Attached is an updated version of the meson patchset. > > Nanoreview: I think the patch Thanks for looking! > Subject: [PATCH v5 11/16] meson: prereq: Handle DLSUFFIX in msvc b

Re: [RFC] building postgres with meson -v

2021-11-10 Thread Peter Eisentraut
On 01.11.21 00:24, Andres Freund wrote: Hi, Attached is an updated version of the meson patchset. Nanoreview: I think the patch Subject: [PATCH v5 11/16] meson: prereq: Handle DLSUFFIX in msvc builds similar to other build envs. is good to go. It's not clear why it's needed in this contex

Re: [RFC] building postgres with meson -v

2021-11-09 Thread Peter Eisentraut
On 04.11.21 19:48, Andres Freund wrote: Probably worth putting this in fairly soon independent of whether anything happens wrt meson? OK, done. Let's see what happens. ;-)

Re: [RFC] building postgres with meson -v

2021-11-04 Thread Andres Freund
Hi, On 2021-11-04 19:17:05 +0100, Peter Eisentraut wrote: > On 01.11.21 00:24, Andres Freund wrote: > > - remaining hardcoded configure tests (e.g. ACCEPT_TYPE_ARG*) > > I think we can get rid of that one. Oh, nice! I was somewhat confused by "unsigned int PASCAL" as a type. > That test origi

Re: [RFC] building postgres with meson -v

2021-11-04 Thread Peter Eisentraut
On 01.11.21 00:24, Andres Freund wrote: - remaining hardcoded configure tests (e.g. ACCEPT_TYPE_ARG*) I think we can get rid of that one. That test originally catered to some strange edge cases where the third argument was size_t that was not the same size as int. That is long gone, if it