> From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> From: Andres Freund
> Date: Wed, 21 Sep 2022 20:36:36 -0700
> Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson
>always:
> gcc_warning_script: |
> - time ./configure \
> -
Hi,
On 2022-09-26 14:15:35 -0700, Peter Geoghegan wrote:
> On Mon, Sep 26, 2022 at 1:27 PM Andres Freund wrote:
> > > Some feedback:
> > > * I gather that "running" as it appears in commands like "meson test
> > > --setup running" refers to a particular setup named "running", that
> > > you inven
Hi,
On 2022-09-22 04:29:15 -0400, Andrew Dunstan wrote:
> Now I'll start on buildfarm support. Given my current commitments, this will
> take me a while, but I hope to have a working client by about the beginning
> of November.
Just checking: Any progress on this? Anything I can help with?
I'd l
> From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> From: Andres Freund
> Date: Wed, 21 Sep 2022 20:36:36 -0700
> Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson
>
> ---
> .cirrus.yml| 92 +-
Andres Freund writes:
> Seems like we should have a different pg_config flag for meson options than
> for configure, and perhaps separately an option to show the buildsystem?
Yeah, probably a good idea, given that shoving the options for one
buildsystem into the other isn't likely to work.
Hi,
On 2022-10-13 23:35:14 -0400, Tom Lane wrote:
> "shiy.f...@fujitsu.com" writes:
> > On Fri, Oct 14, 2022 12:40 AM Andres Freund wrote:
> >> It'd be a fair amount of work, both initially and to maintain it, to
> >> generate
> >> something compatible. I can see some benefit in showing some fe
"shiy.f...@fujitsu.com" writes:
> On Fri, Oct 14, 2022 12:40 AM Andres Freund wrote:
>> It'd be a fair amount of work, both initially and to maintain it, to generate
>> something compatible. I can see some benefit in showing some feature
>> influencing output in --configure, but compatible output
On Fri, Oct 14, 2022 12:40 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-10-13 09:24:51 +, shiy.f...@fujitsu.com wrote:
> > I noticed that `pg_config --configure` didn't show the options given when
> > building with meson.
>
> Yes, that was noted somewhere on this thread.
>
>
> > Maybe it w
Hi,
On 2022-10-13 09:24:51 +, shiy.f...@fujitsu.com wrote:
> I noticed that `pg_config --configure` didn't show the options given when
> building with meson.
Yes, that was noted somewhere on this thread.
> Maybe it would be better if pg_config can output this information, to be
> consistent
Hi,
I noticed that `pg_config --configure` didn't show the options given when
building with meson.
For example,
meson setup build -Dcache=gcc.cache -Ddtrace=enabled -Dicu=enabled
-Dcassert=true -Dprefix=/home/postgres/install_meson/
meson compile -C build
meson install -C build
$ pg_config -
Hi,
On 2022-10-05 10:16:06 +0200, Peter Eisentraut wrote:
> On 04.10.22 05:25, Andres Freund wrote:
> > I've attached a revised version of the xml-tools dependency wrapper (0001):
> > Cleanups, minor error handling improvements, and bit of comment polishing.
> > I'd
> > welcome review. But as it
On 04.10.22 05:25, Andres Freund wrote:
I've attached a revised version of the xml-tools dependency wrapper (0001):
Cleanups, minor error handling improvements, and bit of comment polishing. I'd
welcome review. But as it fixes a build-dependency bug / FIXME, I'm planning
to push it relatively soo
On 03.10.22 09:39, samay sharma wrote:
9f5be26c1215 meson: Add docs for building with meson
I do like the overall layout of this.
The "Supported Platforms" section should be moved back to near the end
of the chapter. I don't see a reason to move it forward, at least
none th
Hi,
On 2022-09-30 15:35:26 -0700, Andres Freund wrote:
> I was thinking of starting at least the following threads / CF entries once a
> few of the remaining things are resolved:
>
> - PGXS compatibility, plus related autoconf simplification patches
> - pkg-config files for building postgres exte
Hi,
On Mon, Sep 26, 2022 at 6:02 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 24.09.22 20:09, Andres Freund wrote:
> > On 2022-09-24 13:52:29 -0400, Tom Lane wrote:
> >> ... btw, shouldn't the CF entry [1] get closed now?
> >
> > Unfortunately not - there's quite a few fol
On Sun, Oct 02, 2022 at 01:38:37PM -0500, Justin Pryzby wrote:
> On Sun, Oct 02, 2022 at 11:05:30AM -0700, Andres Freund wrote:
> > > Also, you wrote "rm -fr build" between building for gcc and clang, but
> > > since they run in an "always" block, it'd be better to use separate
> > > dirs, to allow
On Sun, Oct 02, 2022 at 11:05:30AM -0700, Andres Freund wrote:
> > Also, you wrote "rm -fr build" between building for gcc and clang, but
> > since they run in an "always" block, it'd be better to use separate
> > dirs, to allow seeing logs for the the all (failed) tasks, in case the
> > last one s
Hi,
On 2022-10-02 12:25:20 -0500, Justin Pryzby wrote:
> On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote:
> > From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> > From: Andres Freund
> > Date: Wed, 21 Sep 2022 20:36:36 -0700
> > Subject: [PATCH v17 01/23] meson
On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote:
> From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> From: Andres Freund
> Date: Wed, 21 Sep 2022 20:36:36 -0700
> Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson
This patch isn't f
Hi,
On 2022-09-30 23:51:04 +0200, Peter Eisentraut wrote:
> On 27.09.22 03:19, Andres Freund wrote:
> > Attaches is version 17. Other changes:
> [23 attachments]
>
> How shall we proceed here? The more progress we make, the more patches
> appear. ;-)
> Maybe close this commitfest entry now, and
On 27.09.22 03:19, Andres Freund wrote:
Attaches is version 17. Other changes:
[23 attachments]
How shall we proceed here? The more progress we make, the more patches
appear. ;-)
Maybe close this commitfest entry now, and start new threads for each
subsequent topic.
On Tue, Sep 27, 2022 at 2:41 PM John Naylor
wrote:
>
> On Tue, Sep 27, 2022 at 2:06 AM Andres Freund wrote:
> >
> > On 2022-09-26 15:18:29 +0700, John Naylor wrote:
> > Yea, it's /usr/local on x86-64, based on what was required to make
macos CI
> > work. I updated the wiki page, half-blindly - i
On 26.09.22 18:35, Andres Freund wrote:
9f5be26c1215 meson: Add docs for building with meson
I do like the overall layout of this.
The "Supported Platforms" section should be moved back to near the end
of the chapter. I don't see a reason to move it forward, at least
none that is related to th
On Tue, Sep 27, 2022 at 2:06 AM Andres Freund wrote:
>
> On 2022-09-26 15:18:29 +0700, John Naylor wrote:
> > Either way it doesn't exist on this machine. I was able to get a working
> > build with
> >
> > /usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig
>
> Hm - what did you need this path f
Hi,
On 2022-09-27 17:29:27 +1300, Thomas Munro wrote:
> On Tue, Sep 27, 2022 at 2:19 PM Andres Freund wrote:
> > Subject: [PATCH v17 15/23] windows: Set UMDF_USING_NTSTATUS globally,
> > include ntstatus.h
>
> No Windows expertise here, but this looks reasonable. I originally
> tried to contai
On Tue, Sep 27, 2022 at 2:19 PM Andres Freund wrote:
> Subject: [PATCH v17 15/23] windows: Set UMDF_USING_NTSTATUS globally, include
> ntstatus.h
No Windows expertise here, but this looks reasonable. I originally
tried to contain UMDF_USING_NTSTATUS to small translation units for
fear of uninte
On Mon, Sep 26, 2022 at 1:27 PM Andres Freund wrote:
> > Some feedback:
> > * I gather that "running" as it appears in commands like "meson test
> > --setup running" refers to a particular setup named "running", that
> > you invented as part of creating a meson-ish substitute for
> > installcheck.
Hi,
On 2022-09-26 12:47:14 -0700, Peter Geoghegan wrote:
> On Sun, Sep 25, 2022 at 5:38 PM Andres Freund wrote:
> > # run just the main pg_regress tests against existing server
> > meson test --setup running main/regress-running
>
> > Peter, would this address your use case?
>
> I tried out you
On Sun, Sep 25, 2022 at 5:38 PM Andres Freund wrote:
> # run just the main pg_regress tests against existing server
> meson test --setup running main/regress-running
> Peter, would this address your use case?
I tried out your v16 patchset, which seems to mostly work as I'd hoped
it would. Some f
Hi,
On 2022-09-26 09:35:16 -0700, Andres Freund wrote:
> > 9c00d355d0e9 meson: Add PGXS compatibility
> >
> > This looks like a reasonable direction to me. How complete is it? It
> > says it works for some extensions but not others. How do we define
> > the target line here?
>
> Yea, those are
Hi,
On 2022-09-26 15:18:29 +0700, John Naylor wrote:
> On Wed, Sep 21, 2022 at 7:11 AM Andres Freund wrote:
> >
> > I added installation instructions for meson for a bunch of platforms, but
>
> A couple more things for the wiki:
>
> 1) /opt/homebrew/ seems to be an "Apple silicon" path?
Yea, i
Hi,
On 2022-09-26 15:01:56 +0200, Peter Eisentraut wrote:
> Here is some review of the remaining ones (might not match exactly what you
> attached, I was working off your branch):
Thanks, and makes sense.
> 9f789350a7a7 meson: ci: wip: move compilerwarnings task to meson
>
> This sounds reasona
Hi,
On 2022-09-26 10:41:01 +0200, Alvaro Herrera wrote:
> On 2022-Sep-25, Andres Freund wrote:
>
> > From 3eb0ca196084da314d94d1e51c7b775012a4773c Mon Sep 17 00:00:00 2001
> > From: Andres Freund
> > Date: Wed, 21 Sep 2022 11:03:07 -0700
> > Subject: [PATCH v16 04/16] meson: Add windows resource
On 24.09.22 20:09, Andres Freund wrote:
On 2022-09-24 13:52:29 -0400, Tom Lane wrote:
... btw, shouldn't the CF entry [1] get closed now?
Unfortunately not - there's quite a few followup patches that haven't been
[fully] reviewed and thus not applied yet.
Here is some review of the remaining
On 2022-Sep-25, Andres Freund wrote:
> From 3eb0ca196084da314d94d1e51c7b775012a4773c Mon Sep 17 00:00:00 2001
> From: Andres Freund
> Date: Wed, 21 Sep 2022 11:03:07 -0700
> Subject: [PATCH v16 04/16] meson: Add windows resource files
> diff --git a/src/backend/jit/llvm/meson.build
> b/src/back
On Wed, Sep 21, 2022 at 7:11 AM Andres Freund wrote:
>
> I added installation instructions for meson for a bunch of platforms, but
A couple more things for the wiki:
1) /opt/homebrew/ seems to be an "Apple silicon" path? Either way it
doesn't exist on this machine. I was able to get a working bu
On Mon, Sep 26, 2022 at 14:47 PM Andres Freund wrote:
> Hi,
>
> On 2022-09-26 06:24:42 +, wangw.f...@fujitsu.com wrote:
> > I tried to use meson and ninja and they are really efficient.
> > But when I tried to specify "c_args", it did not take effect.
>
> They should take effect, but won't b
Hi,
On 2022-09-26 06:24:42 +, wangw.f...@fujitsu.com wrote:
> I tried to use meson and ninja and they are really efficient.
> But when I tried to specify "c_args", it did not take effect.
They should take effect, but won't be shown in the summary section
currently. That currently only shows t
Hi,
I tried to use meson and ninja and they are really efficient.
But when I tried to specify "c_args", it did not take effect.
Attached my steps:
[In the HEAD (7d708093b7)]
$ meson setup build --prefix /home/wangw/install/parallel_apply/ -Dcassert=true
-Dtap_tests=enabled -Dicu=enabled -Dc_args
Hi,
On 2022-09-24 17:33:49 -0700, Peter Geoghegan wrote:
> On Sat, Sep 24, 2022 at 5:13 PM Andres Freund wrote:
> > > One more question about this, that wasn't covered by the Wiki page: is
> > > there some equivalent to "make installcheck" with meson builds?
> >
> > Not yet. Nothing impossible, j
On Sat, Sep 24, 2022 at 5:13 PM Andres Freund wrote:
> > One more question about this, that wasn't covered by the Wiki page: is
> > there some equivalent to "make installcheck" with meson builds?
>
> Not yet. Nothing impossible, just not done yet. Partially because installcheck
> is so poorly defi
Hi,
On 2022-09-24 16:56:20 -0700, Peter Geoghegan wrote:
> On Thu, Sep 22, 2022 at 2:50 PM Andres Freund wrote:
> > meson:
> >
> > time meson test
> > real0m42.178s
> > user7m8.533s
> > sys 2m17.711s
>
> I find that a more or less comparable test run on my workstation
> (which has a
On Thu, Sep 22, 2022 at 2:50 PM Andres Freund wrote:
> meson:
>
> time meson test
> real0m42.178s
> user7m8.533s
> sys 2m17.711s
I find that a more or less comparable test run on my workstation
(which has a Ryzen 9 5950X) takes just over 38 seconds. I think that
the improvement is far
... btw, shouldn't the CF entry [1] get closed now?
The cfbot's unhappy that the last patch no longer applies.
regards, tom lane
[1] https://commitfest.postgresql.org/39/3395/
On Thu, Sep 22, 2022 at 01:28:09PM -0700, Andres Freund wrote:
> On 2022-09-22 13:05:33 -0700, Nathan Bossart wrote:
>> * I'm using an Ubuntu-based distribution, and the version of meson that apt
>> installed was not new enough for Postgres. I ended up cloning meson [0]
>> and using the newest tag
On Thu, Sep 22, 2022 at 2:50 PM Andres Freund wrote:
> I'm likely the most biased person on this, but for me the reliable incremental
> builds and the readability of the test output are big enough wins that the
> answer is pretty clear... Doesn't hurt that running all tests is faster too.
It's ni
Hi,
On 2022-09-22 13:21:28 -0700, Peter Geoghegan wrote:
> Is it generally recommended that individual hackers mostly switch over
> to Meson for their day to day work soon? I'm guessing that this
> question doesn't really have a clear answer yet, but thought I'd ask,
> just in case.
It'll probabl
Hi,
On 2022-09-22 13:05:33 -0700, Nathan Bossart wrote:
> I gave the meson build system a try, and it seems to work nicely. It
> didn't take long at all to adapt my workflow.
>
> A few notes from my experience:
>
> * I'm using an Ubuntu-based distribution, and the version of meson that apt
> in
On Thu, Sep 22, 2022 at 1:05 PM Nathan Bossart wrote:
> Otherwise, all of my usual build options, ccache, etc. are working just
> like before. Nice work!
+1
Is it generally recommended that individual hackers mostly switch over
to Meson for their day to day work soon? I'm guessing that this
que
I gave the meson build system a try, and it seems to work nicely. It
didn't take long at all to adapt my workflow.
A few notes from my experience:
* I'm using an Ubuntu-based distribution, and the version of meson that apt
installed was not new enough for Postgres. I ended up cloning meson [0]
On 2022-Sep-22, Tom Lane wrote:
> Ah, right, the joys of maintaining multiple build systems. I wonder
> if there's any way to avoid that by scraping file lists from one
> group to the other.
Or maybe we could have a file common to both, say OBJS, which both
scrape in their own way. That could b
Hi,
On 2022-09-22 04:29:15 -0400, Andrew Dunstan wrote:
> Great. Now I'll start on buildfarm support. Given my current
> commitments, this will take me a while, but I hope to have a working
> client by about the beginning of November.
Great! Let me know if there's something I can do to help.
Gre
Hi,
On 2022-09-22 16:56:57 +0200, Alvaro Herrera wrote:
> On 2022-Sep-22, Tom Lane wrote:
> > Initial reports from the cfbot are mostly promising, but there are a few
> > patches where all the meson builds fail while all the autoconf ones pass,
> > so there's something for you to look at. So far
Alvaro Herrera writes:
> On 2022-Sep-22, Tom Lane wrote:
>> Initial reports from the cfbot are mostly promising, but there are a few
>> patches where all the meson builds fail while all the autoconf ones pass,
>> so there's something for you to look at. So far CF entries 3464, 3733,
>> 3771, 3808
On 2022-Sep-22, Tom Lane wrote:
> Initial reports from the cfbot are mostly promising, but there are a few
> patches where all the meson builds fail while all the autoconf ones pass,
> so there's something for you to look at. So far CF entries 3464, 3733,
> 3771, 3808 look that way.
Hmm, but tho
Andres Freund writes:
> On 2022-09-21 09:46:30 -0700, Andres Freund wrote:
>> I'm planning to commit this today, unless somebody wants to argue against
>> that.
> And done!
Yay!
Initial reports from the cfbot are mostly promising, but there are a few
patches where all the meson builds fail whil
On 2022-09-22 Th 01:57, Andres Freund wrote:
> Hi,
>
> On 2022-09-21 09:46:30 -0700, Andres Freund wrote:
>> I'm planning to commit this today, unless somebody wants to argue against
>> that.
> And done!
>
> Changes:
> - fixed a few typos (thanks Thomas)
> - less duplication in the CI tasks
> - r
Hi,
On 2022-09-21 09:46:30 -0700, Andres Freund wrote:
> I'm planning to commit this today, unless somebody wants to argue against
> that.
And done!
Changes:
- fixed a few typos (thanks Thomas)
- less duplication in the CI tasks
- removed an incomplete implementation of the target for abbrevs.tx
Hi,
On 2022-09-21 09:46:30 -0700, Andres Freund wrote:
> After that I am planning to split the "ci" commit so that it converts a few of
> the CI tasks to use meson, without adding all the other platforms I added for
> development. I think that's important to get in soon, given that it'll
> probabl
On Wed, Sep 21, 2022 at 09:46:30AM -0700, Andres Freund wrote:
> I think we should:
>
> - convert windows to build with ninja - it builds faster, runs all tests,
> parallelizes tests. That means that msbuild based builds don't have coverage
> via CI / cfbot, but we don't currently have the res
Hi,
On 2022-09-21 13:56:37 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I think we should:
>
> > - convert windows to build with ninja - it builds faster, runs all tests,
> > parallelizes tests. That means that msbuild based builds don't have
> > coverage
> > via CI / cfbot, but we do
Andres Freund writes:
> I think we should:
> - convert windows to build with ninja - it builds faster, runs all tests,
> parallelizes tests. That means that msbuild based builds don't have coverage
> via CI / cfbot, but we don't currently have the resources to test both.
Check. The sooner w
Hi,
On 2022-09-21 09:52:48 +0700, John Naylor wrote:
> On Wed, Sep 21, 2022 at 7:11 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2022-09-19 19:16:30 -0700, Andres Freund wrote:
> > > To have some initial "translation" for other developers I've started a
> wiki
> > > page with a translation tabl
On Wed, Sep 21, 2022 at 7:11 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-09-19 19:16:30 -0700, Andres Freund wrote:
> > To have some initial "translation" for other developers I've started a
wiki
> > page with a translation table. Still very WIP:
> > https://wiki.postgresql.org/wiki/Meson
> >
> >
Hi,
On 2022-09-19 19:16:30 -0700, Andres Freund wrote:
> To have some initial "translation" for other developers I've started a wiki
> page with a translation table. Still very WIP:
> https://wiki.postgresql.org/wiki/Meson
>
> For now, a bit of polishing aside, I'm just planning to add a minimal
Hi,
On 2022-09-19 05:25:59 -0400, Peter Eisentraut wrote:
> IMO, the following commits are ready to be pushed now:
Slowly working through them.
To have some initial "translation" for other developers I've started a wiki
page with a translation table. Still very WIP:
https://wiki.postgresql.org/
On 19.09.22 02:29, Andres Freund wrote:
Hi,
On September 18, 2022 5:24:06 PM PDT, Peter Eisentraut
wrote:
On 15.09.22 04:26, Andres Freund wrote:
Attached is v13 of the meson patchset. The biggest changes are:
Did something about warning flags change from the previous patch set? I see
it
Hi,
On September 18, 2022 5:24:06 PM PDT, Peter Eisentraut
wrote:
>On 15.09.22 04:26, Andres Freund wrote:
>> Attached is v13 of the meson patchset. The biggest changes are:
>
>Did something about warning flags change from the previous patch set? I see
>it's building with -Wextra now, which c
On 15.09.22 04:26, Andres Freund wrote:
Attached is v13 of the meson patchset. The biggest changes are:
Did something about warning flags change from the previous patch set? I
see it's building with -Wextra now, which combined with -Werror causes
the build to fail for me. I have never encou
Hi,
On 2022-09-16 16:22:35 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-09-16 09:14:20 +1200, Thomas Munro wrote:
> >> On Thu, Sep 15, 2022 at 2:26 PM Andres Freund wrote:
> >>> - noticed that libpgport.a had and needed a dependency on errcodes.h -
> >>> that
> >>> seemed wrong. T
Andres Freund writes:
> On 2022-09-16 09:14:20 +1200, Thomas Munro wrote:
>> On Thu, Sep 15, 2022 at 2:26 PM Andres Freund wrote:
>>> - noticed that libpgport.a had and needed a dependency on errcodes.h - that
>>> seemed wrong. The dependency is due to src/port/*p{read,write}v?.c including
>>> po
Hi,
On 2022-09-16 09:14:20 +1200, Thomas Munro wrote:
> On Thu, Sep 15, 2022 at 2:26 PM Andres Freund wrote:
> > - noticed that libpgport.a had and needed a dependency on errcodes.h - that
> > seemed wrong. The dependency is due to src/port/*p{read,write}v?.c
> > including
> > postgres.h - w
Hi,
On 2022-09-16 09:14:20 +1200, Thomas Munro wrote:
> GCC 12 produces a bunch of warnings by default with meson, and that
> turned out to be because the default optimisation level is -O3.
> That's a change from the make build, which uses -O2. Should we set a
> default of 2, or is there some mes
On Thu, Sep 15, 2022 at 2:26 PM Andres Freund wrote:
> - noticed that libpgport.a had and needed a dependency on errcodes.h - that
> seemed wrong. The dependency is due to src/port/*p{read,write}v?.c including
> postgres.h - which seems wrong. So I added a patch changing them to include
> c.
Hi,
On 2022-09-15 01:10:16 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I'm inclined to build the static lib on windows as long as we do it on other
> > platforms.
>
> Maybe I spent too much time working for Red Hat, but I'm kind of
> unhappy that we build static libraries at all.
Yea, I
Andres Freund writes:
> I'm inclined to build the static lib on windows as long as we do it on other
> platforms.
Maybe I spent too much time working for Red Hat, but I'm kind of
unhappy that we build static libraries at all. They are maintenance
hazards and therefore security hazards by definit
76 matches
Mail list logo
