This entry has been waiting on author input for a while (our current
threshold is roughly two weeks), so I've marked it Returned with
Feedback.
Once you think the patchset is ready for review again, you (or any
interested party) can resurrect the patch entry by visiting
https://commitfest.pos
Hi,
On Thu, Jul 14, 2022 at 08:51:24AM +0200, Antonin Houska wrote:
> Shouldn't the patch status be set to "Waiting on Author"?
>
> (I was curious if this is a patch that I can review.)
Ah indeed, I just updated the CF entry!
Shouldn't the patch status be set to "Waiting on Author"?
(I was curious if this is a patch that I can review.)
Julien Rouhaud wrote:
> On Wed, Jun 22, 2022 at 11:05:54PM +, Imseih (AWS), Sami wrote:
> > >Can you describe how it's kept in sync, and how it makes sure that the
> > > prop
On Wed, Jun 22, 2022 at 11:05:54PM +, Imseih (AWS), Sami wrote:
> >Can you describe how it's kept in sync, and how it makes sure that the
> > property
> >is maintained over restart / gc? I don't see any change in the code for
> > the
> >2nd part so I don't see how it could work (
Hi,
On Tue, Jun 21, 2022 at 08:04:01PM +, Imseih (AWS), Sami wrote:
>
> I separated the pg_stat_statements patch. The patch
> Introduces a secondary hash that tracks locations of
> A query ( by queryid ) in the external file.
I still think that's wrong.
> The hash
> remains in lockstep with
>AFAICS you're proposing to add an identifier for a specific plan, but no
> way to
>know what that plan was? How are users supposed to use the information if
> they
>know something changed but don't know what changed exactly?
I see this as a start to do more useful things with plans
On 15/6/2022 21:45, Imseih (AWS), Sami wrote:
Adding a plan_id to pg_stat_activity allows users
to determine if a plan for a particular statement
has changed and if the new plan is performing better
or worse for a particular statement.
There are several ways the plan_id in pg_stat_activity
In ge
Hi,
On Wed, Jun 15, 2022 at 06:45:38PM +, Imseih (AWS), Sami wrote:
> Adding a plan_id to pg_stat_activity allows users
> to determine if a plan for a particular statement
> has changed and if the new plan is performing better
> or worse for a particular statement.
> [...]
> Attached is a POC
