Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-05-31 Thread Tom Lane
Thomas Munro writes: > It's slightly tricky to get smgr to behave differently because of the > contents of a system catalogue! The mere thought makes me blanch. I'm okay with the GUC part, but I do not think we should put in 0002 --- the odds of causing serious problems greatly outweigh the valu

Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-05-31 Thread Tomas Vondra
On 5/31/25 16:00, Thomas Munro wrote: > On Fri, May 30, 2025 at 3:58 AM Dimitrios Apostolou wrote: >> All I'm saying is that this is a regression for PostgreSQL users that keep >> tablespaces on compressed Btrfs. What could be done from postgres, is to >> provide a runtime setting for avoiding fal

Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-05-31 Thread Thomas Munro
Or for a completely different approach: I wonder if ftruncate() would be more efficient on COW systems anyway. The minimum thing we need is for the file system to remember the new size, 'cause, erm, we don't. All the rest is probably a waste of cycles, since they reserve real space (or fail to) la

Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-05-31 Thread Thomas Munro
On Fri, May 30, 2025 at 3:58 AM Dimitrios Apostolou wrote: > All I'm saying is that this is a regression for PostgreSQL users that keep > tablespaces on compressed Btrfs. What could be done from postgres, is to > provide a runtime setting for avoiding fallocate(), going instead through > the old c

Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-05-29 Thread Dimitrios Apostolou
On Wed, 28 May 2025, Tomas Vondra wrote: Isn't guaranteeing success of a write a general issue with compressed filesystem? Why is posix_fallocate() any special in this regard? Shouldn't the filesystem be defensive and assume the data is not compressible? Or maybe just return EOPNOTSUPP when in d

Re: [PING] fallocate() causes btrfs to never compress postgresql files

2025-05-28 Thread Tomas Vondra
On 5/28/25 16:22, Dimitrios Apostolou wrote: > Hello, sorry for mass sending this, but I didn't get any response to my > first email [1] so I'm now CC'ing the commit's 4d330a6 [2] author and > the reviewers. I think it's an important issue, because I need to > custom-compile postgresql to have wh