Re: [PATCH] psql : Improve code for help option

2021-03-04 Thread Fujii Masao
On 2021/03/03 17:05, Nitin Jadhav wrote: Hi, I have reviewed the patch and it looks good to me. Thanks! Pushed. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

Re: [PATCH] psql : Improve code for help option

2021-03-03 Thread Nitin Jadhav
Hi, I have reviewed the patch and it looks good to me. Thanks and Regards, Nitin Jadhav On Wed, Mar 3, 2021 at 1:09 PM Fujii Masao wrote: > > > On 2021/03/03 12:27, miyake_kouta wrote: > > 2021-03-03 00:09, Fujii Masao wrote: > >> We can simplify the code more and remove "env = user" > >> by j

Re: [PATCH] psql : Improve code for help option

2021-03-02 Thread Fujii Masao
On 2021/03/03 12:27, miyake_kouta wrote: 2021-03-03 00:09, Fujii Masao wrote: We can simplify the code more and remove "env = user" by just using "user" instead of "env" in the above? Thank you for your comment. I updated my patch and replaced "env" with "user". Please check. Thanks for u

Re: [PATCH] psql : Improve code for help option

2021-03-02 Thread miyake_kouta
2021-03-03 00:09, Fujii Masao wrote: We can simplify the code more and remove "env = user" by just using "user" instead of "env" in the above? Thank you for your comment. I updated my patch and replaced "env" with "user". Please check. Regards. -- Kota Miyake diff --git a/src/bin/psql/help.c b

Re: [PATCH] psql : Improve code for help option

2021-03-02 Thread Fujii Masao
On 2021/03/02 11:57, miyake_kouta wrote: Hi. I found some redundant code in psql/help.c, so I propose a patch to fix it. In the current help.c, the variable "user" is set to the value of $PGUSER (or get_user_name). However, $PGUSER is referenced again in the code that follows. We can replace