Hi Tom,
Thanks a lot for pushing this through.
In complete agreement on fixing mbstrlen, it would clearly have lead to cut
off string sends, or worse (does the binary protocol use null terminated
strings, or are they length prefixed?). Apologies anyways, it's been a
while so I don't know how it m
I wrote:
> Fortunately for the odds of getting this patch accepted, we just
> pushed an ALTER TYPE improvement that will solve your problem [1].
> Please replace ltree--1.2.sql with an upgrade script that uses
> that, and resubmit.
I decided it would be a shame for this to miss v13, seeing that
(a
Nino Floris writes:
> Attached is the new patch rebased onto master.
The approach of simply providing a 1.2 installation script, with no
upgrade path from 1.1, is surely not going to be acceptable to anyone
who's using ltree in production.
Fortunately for the odds of getting this patch accepted,
Attached is the new patch rebased onto master.
Best regards,
Nino Floris
On Thu, Jan 16, 2020 at 11:00 PM Tomas Vondra
wrote:
>
> On Fri, Nov 29, 2019 at 11:29:03AM +0900, Michael Paquier wrote:
> >On Mon, Nov 11, 2019 at 03:44:54PM +0100, Nino Floris wrote:
> >> Alright, as usual life got in th
On Fri, Nov 29, 2019 at 11:29:03AM +0900, Michael Paquier wrote:
On Mon, Nov 11, 2019 at 03:44:54PM +0100, Nino Floris wrote:
Alright, as usual life got in the way. I've attached a new version of
the patch with pgindent changes.
> What do you think about writing patch for ALTER TYPE?
I'd rather
On Mon, Nov 11, 2019 at 03:44:54PM +0100, Nino Floris wrote:
> Alright, as usual life got in the way. I've attached a new version of
> the patch with pgindent changes.
>
> > What do you think about writing patch for ALTER TYPE?
> I'd rather not :$
>
> > 1) Write migration script, which directly u
Alright, as usual life got in the way. I've attached a new version of
the patch with pgindent changes.
> What do you think about writing patch for ALTER TYPE?
I'd rather not :$
> 1) Write migration script, which directly updates pg_type.
This sounds like the best option right now, if we don't wan
Hello, can you please post an updated version of this patch? Note that
Travis has a small complaint:
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security
-fno-strict-aliasing -fwrapv -fexcess-precisi
On Wed, Sep 11, 2019 at 9:45 PM Nino Floris wrote:
> > * We currently don't add new extension SQL-script for new extension
> > version (i.e. ltree--1.2.sql). Instead, we provide just a migration
> > script (i.e. ltree--1.1--1.2.sql). This simplifies testing of
> > extension migration – plain ex
Hi Alexander,
Thanks for the initial review!
> * Your patch doesn't follow coding convention. In particular, it
> uses spaces for indentation instead of tabs. Moreover, it changes
> tags to spaces in places it doesn't touch. As the result, patch is
> "dirty". Looks like your IDE isn't properl
Hi!
On Sun, Aug 18, 2019 at 6:53 PM Nino Floris wrote:
> Attached is a patch to support send/recv on ltree, lquery and ltxtquery.
> I'm a contributor to the Npgsql .NET PostgreSQL driver and we'll be
> the first to have official support once those ltree changes have been
> released.
> You can fin
11 matches
Mail list logo
