Re: [PATCH] fix for C4141 warning on MSVC

2018-01-23 Thread Tom Lane
Thomas Munro writes: > Here's one like that. Pushed; we'll soon see if the buildfarm likes it. I added a tweak to prevent forced inlining at -O0, as discussed in the other thread; and worked on the comments a bit. regards, tom lane

Re: [PATCH] fix for C4141 warning on MSVC

2018-01-23 Thread Thomas Munro
On Wed, Jan 24, 2018 at 1:42 PM, Tom Lane wrote: > Thomas Munro writes: >> On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev >> wrote: >>> Just very small fix for C4141 warning > >> Thanks. This is similar to the fix I proposed over here: >> https://www.postgresql.org/message-id/CAEepm%3D2iTKvb

Re: [PATCH] fix for C4141 warning on MSVC

2018-01-23 Thread Tom Lane
Thomas Munro writes: > On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev > wrote: >> Just very small fix for C4141 warning > Thanks. This is similar to the fix I proposed over here: > https://www.postgresql.org/message-id/CAEepm%3D2iTKvbebiK3CdoczQk4_FfDt1EeU4c%2BnGE340JH7gQ0g%40mail.gmail.com

Re: [PATCH] fix for C4141 warning on MSVC

2018-01-23 Thread Thomas Munro
On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev wrote: > Just very small fix for C4141 warning > (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4141). > > Also could be viewed on Github - > https://github.com/michail-nikolaev/postgres/commit/38a5