On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote:
> Thanks for addressing the comment.
>
> In PG code, we start a multiline comment with just /* on the first
> line and end with just */ on the last line. All the lines in-between
> start with * . Please check other comments in the fil
Michael Paquier writes:
> Hmm. I don't think that grouping all these details in the same
> comment block is an improvement in this case compared to the first
> version, where it is clear which part of the calculation applies to
> what. In short, I'm OK with how things are on HEAD.
+1. When I s
On Tue, Apr 08, 2025 at 01:26:59AM -0400, Tom Lane wrote:
> +1. When I saw the patch I was mainly afraid that pgindent would
> make a hash of it.
Yes. I was actually surprised to see that it did not mess up with the
code generated.
--
Michael
signature.asc
Description: PGP signature
On Tue, Apr 8, 2025 at 10:49 AM Michael Paquier wrote:
>
> On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote:
> > Thanks for addressing the comment.
> >
> > In PG code, we start a multiline comment with just /* on the first
> > line and end with just */ on the last line. All the lines
On Tue, Apr 8, 2025 at 12:08 AM Steve Chavez wrote:
>
> I haven't found a similar style of comment on any other function call.
>
> I've attached a new patch using the style you suggest.
>
> That being said, I do find the first form much more readable, but I
> understand this is a debatable subjec
I haven't found a similar style of comment on any other function call.
I've attached a new patch using the style you suggest.
That being said, I do find the first form much more readable, but I
understand this is a debatable subject.
Best regards,
Steve Chavez
On Mon, 7 Apr 2025 at 06:33, Ashut
On Mon, Apr 7, 2025 at 3:19 AM Michael Paquier wrote:
>
> On Sun, Apr 06, 2025 at 12:37:24PM -0500, Steve Chavez wrote:
> > I found the numbers in `quote_literal_cstr` palloc quite magical. So I've
> > added a comment clarifying what they mean. The change is small:
> >
> > /* We make a wor
On Sun, Apr 06, 2025 at 12:37:24PM -0500, Steve Chavez wrote:
> I found the numbers in `quote_literal_cstr` palloc quite magical. So I've
> added a comment clarifying what they mean. The change is small:
>
> /* We make a worst-case result area; wasting a little space is OK */
> - res
