> On 23 Apr 2025, at 22:26, Jacob Champion
> wrote:
>
> On Tue, Apr 22, 2025 at 12:45 PM Jacob Champion
> wrote:
>> Great, thanks for the quick review!
>
> And pushed. Thanks everyone!
Congratulations on your first commit, looking forward to many more to come!
--
Daniel Gustafsson
On Tue, Apr 22, 2025 at 12:45 PM Jacob Champion
wrote:
> Great, thanks for the quick review!
And pushed. Thanks everyone!
--Jacob
On Tue, Apr 22, 2025 at 3:17 PM Jelte Fennema-Nio wrote:
> The way you replaced this does not have the same behaviour in the case
> where the prefix/suffix is not part of the string. removeprefix/suffix
> will not remove any characters in that case, but your code will always
> remove the number of
On Tue, 22 Apr 2025 at 21:26, Jacob Champion
wrote:
> - str.removeprefix/suffix() (3.9)
The way you replaced this does not have the same behaviour in the case
where the prefix/suffix is not part of the string. removeprefix/suffix
will not remove any characters in that case, but your code will alw
On Tue, Apr 22, 2025 at 2:43 PM Renan Alves Fonseca
wrote:
> I did a quick test on 3.5.
Thanks!
> It seems to work after removing
> f-strings... At this point, I would be really happy with 3.6.
Ah, makes sense. Well, I'm starting with the 3.6 fix regardless, since
it's preventing RHEL8 testing.
Jacob Champion writes:
>
> This is tested against Python 3.6.15 (3.6 went EOL at the end of
> 2021). I'm working on getting Rocky 8 installed locally to test
> against. If it's decided we want to support downwards to 3.5, I will
> test there too (but I hope we don't; see parent thread).
>
I did
Jacob Champion writes:
> I'm considering committing this myself.
Please do.
> Do you mind if it takes a day
> or so to get this in, while I quadruple-check everything, or are you
> blocked on this?
I'm not in a hurry. Push when you're ready.
regards, tom lane
On Tue, Apr 22, 2025 at 12:36 PM Tom Lane wrote:
> Thanks! I confirm this works for me on RHEL8 with 3.6.8.
Great, thanks for the quick review!
I'm considering committing this myself. Do you mind if it takes a day
or so to get this in, while I quadruple-check everything, or are you
blocked on t
Jacob Champion writes:
> This is tested against Python 3.6.15 (3.6 went EOL at the end of
> 2021). I'm working on getting Rocky 8 installed locally to test
> against. If it's decided we want to support downwards to 3.5, I will
> test there too (but I hope we don't; see parent thread).
Thanks! I
