Re: [PATCH] Move clause_sides_match_join() into pathnode.h

2024-10-15 Thread David Rowley
On Fri, 11 Oct 2024 at 04:25, James Hunter wrote: > Moved into restrictinfo.h, instead, in next revision. Thanks. Pushed. > > (I really wonder how much the inlining is giving us given that the > > function itself calls other non-inlineable functions) > > I wondered the same! But, at least the br

Re: [PATCH] Move clause_sides_match_join() into pathnode.h

2024-10-10 Thread James Hunter
On Wed, Oct 9, 2024 at 5:26 PM David Rowley wrote: > > On Thu, 10 Oct 2024 at 08:38, James Hunter wrote: > > We had two almost-identical copies of the utility function > > clause_sides_match_join() -- one in joinpath.c, and one in > > analyzejoins.c. Both copies were marked "inline," so we might

Re: [PATCH] Move clause_sides_match_join() into pathnode.h

2024-10-09 Thread David Rowley
On Thu, 10 Oct 2024 at 08:38, James Hunter wrote: > We had two almost-identical copies of the utility function > clause_sides_match_join() -- one in joinpath.c, and one in > analyzejoins.c. Both copies were marked "inline," so we might as well > just move the (inline) function definition into a co