Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-16 Thread Tristan Partin
On Fri Jun 16, 2023 at 5:10 PM CDT, Dagfinn Ilmari Mannsåker wrote: > Andres Freund writes: > > > Hi, > > > > On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote: > >> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You > >> can only get at %INC by loading the module, which

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-16 Thread Dagfinn Ilmari Mannsåker
Andres Freund writes: > Hi, > > On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote: >> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You >> can only get at %INC by loading the module, which in many cases will have >> side effects. > > I was envisioning using %INC after t

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-16 Thread Andres Freund
Hi, On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote: > Unless I'm misunderstanding, this doesn't look terribly feasible to me. You > can only get at %INC by loading the module, which in many cases will have > side effects. I was envisioning using %INC after the use/require block - I don't thin

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-16 Thread Andrew Dunstan
On 2023-06-14 We 15:32, Andres Freund wrote: Hi, On 2023-06-09 11:43:54 -0700, Andres Freund wrote: On 2023-06-02 10:13:44 -0500, Tristan Partin wrote: On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote: Hi, On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: I wonder if we instead cou

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-14 Thread Tristan Partin
On Wed Jun 14, 2023 at 2:32 PM CDT, Andres Freund wrote: > Hi, > > On 2023-06-09 11:43:54 -0700, Andres Freund wrote: > > On 2023-06-02 10:13:44 -0500, Tristan Partin wrote: > > > On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote: > > > > Hi, > > > > > > > > On 2023-06-02 08:10:43 -0500, Trist

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-14 Thread Andres Freund
Hi, On 2023-06-09 11:43:54 -0700, Andres Freund wrote: > On 2023-06-02 10:13:44 -0500, Tristan Partin wrote: > > On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote: > > > Hi, > > > > > > On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: > > > > > I wonder if we instead could just make perl o

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-09 Thread Andres Freund
Hi, On 2023-06-09 13:58:46 -0500, Tristan Partin wrote: > Patch looks good to me! Thanks for the report Ilmari and the review Tristan! Pushed the fix. Regards, Andres

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-09 Thread Tristan Partin
Patch looks good to me! -- Tristan Partin Neon (https://neon.tech)

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-09 Thread Andres Freund
Hi, On 2023-06-02 10:13:44 -0500, Tristan Partin wrote: > On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote: > > Hi, > > > > On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: > > > > I wonder if we instead could just make perl output the files it loads > > > > and > > > > handle dependenci

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Tristan Partin
On Fri Jun 2, 2023 at 8:47 AM CDT, Andres Freund wrote: > Hi, > > On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: > > > I wonder if we instead could just make perl output the files it loads and > > > handle dependencies automatically that way? But that's more work, so it's > > > probably the ri

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Andres Freund
Hi, On 2023-06-02 08:10:43 -0500, Tristan Partin wrote: > > I wonder if we instead could just make perl output the files it loads and > > handle dependencies automatically that way? But that's more work, so it's > > probably the right thing to go for the manual path for now. > > I am not familar

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Tristan Partin
On Fri Jun 2, 2023 at 8:00 AM CDT, Andres Freund wrote: > Hi, > > On 2023-06-01 23:06:04 -0500, Tristan Partin wrote: > > In our case, we should add the ^line to src/backend/catalog/meson.build. > > src/backend is only reached well after src/include, due to needing > dependencies on files generated

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-02 Thread Andres Freund
Hi, On 2023-06-01 23:06:04 -0500, Tristan Partin wrote: > In our case, we should add the ^line to src/backend/catalog/meson.build. src/backend is only reached well after src/include, due to needing dependencies on files generated in src/include. I wonder if we instead could just make perl output

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-01 Thread Tristan Partin
On Thu Jun 1, 2023 at 4:22 PM CDT, Dagfinn Ilmari Mannsåker wrote: > On Thu, 1 Jun 2023, at 22:16, Tristan Partin wrote: > > Could you create a variable for the file instead of calling files() 3 > > times? > > > >> catalog_pm = files('path/to/Catalog.pm') > > Sure, but which meson.build file should

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-01 Thread Dagfinn Ilmari Mannsåker
On Thu, 1 Jun 2023, at 22:16, Tristan Partin wrote: > Could you create a variable for the file instead of calling files() 3 > times? > >> catalog_pm = files('path/to/Catalog.pm') Sure, but which meson.build file should it go in? I know nothing about meson variable scoping. > -- > Tristan Partin

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-01 Thread Tristan Partin
Could you create a variable for the file instead of calling files() 3 times? > catalog_pm = files('path/to/Catalog.pm') -- Tristan Partin Neon (https://neon.tech)

Re: [PATCH] Missing dep on Catalog.pm in meson rules

2023-06-01 Thread Michael Paquier
On Thu, Jun 01, 2023 at 01:41:40PM +0100, Dagfinn Ilmari Mannsåker wrote: > While hacking on Catalog.pm (over in > https://postgr.es/m/87y1l3s7o9.fsf%40wibble.ilmari.org) I noticed that > ninja wouldn't rebuild postgres.bki on changes to the module. Here's a > patch that adds it to depend_files fo