Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest

2024-07-02 Thread Jelte Fennema-Nio
On Tue, 2 Jul 2024 at 10:15, Aleksander Alekseev wrote: > The referred patch was rejected at first because it didn't modify > nodeSeqScan.c to make use of the change within the core. I guess we interpret Heikis email differently. I read it as: "If this improves performance, then let's also start

Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest

2024-07-02 Thread Aleksander Alekseev
Hi, > > As I recall, previously it was argued that changes like this should > > have some use within the core [1]. > > I don't see that argument anywhere in the thread honestly. I did see > heiki asking why it would be useful for extensions, but that was > answered there. The referred patch was r

Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest

2024-07-02 Thread Jelte Fennema-Nio
On Mon, 1 Jul 2024 at 15:48, Aleksander Alekseev wrote: > As I recall, previously it was argued that changes like this should > have some use within the core [1]. I don't see that argument anywhere in the thread honestly. I did see heiki asking why it would be useful for extensions, but that was

Re: [PATCH] Handle SK_SEARCHNULL and SK_SEARCHNOTNULL in HeapKeyTest

2024-07-01 Thread Aleksander Alekseev
Hi, > This patches changes the HeapKeyTest macro to add handling for SK_SEARCHNULL > and SK_SEARCHNOTNULL. While currently no core codes uses these ScanKey flags > it would be useful for extensions if it was supported so extensions > dont have to implement > handling for those by themself. As I r