Re: [PATCH] Fixed creation of empty .log files during log rotation

2025-03-15 Thread vignesh C
On Tue, 29 Oct 2024 at 13:38, Арсений Косицын wrote: > > > Hi everyone! > > A situation has been discovered in which empty .log files are being created. > > --Reproduce: > > 1) You need to set the following parameters in the "postgresql.conf" file: > > log_destination = 'csvlog' > logging_collecto

Re: [PATCH] Fixed creation of empty .log files during log rotation

2024-12-19 Thread Michael Paquier
On Fri, Dec 13, 2024 at 02:21:45PM +0300, Arseny Kositsin wrote: > 08.12.2024 01:06, Tomas Vondra wrote: >> In fact, isn't it wrong to do the check outside? logfile_rotate_dest() >> is responsible for closing the log files too, and with the check outside >> we keep the first .log file open forever

Re: [PATCH] Fixed creation of empty .log files during log rotation

2024-12-13 Thread Arseny Kositsin
Hi, Tomas. 08.12.2024 01:06, Tomas Vondra wrote: > Yeah, creating all those files seems rather unnecessary. But wouldn't it > be easier to do the check in logfile_rotate_dest(), instead of for each > call? I think something like this would do the trick: > > @@ -1292,6 +1292,9 @@ logfile_rotate_d

Re: [PATCH] Fixed creation of empty .log files during log rotation

2024-12-07 Thread Tomas Vondra
On 10/29/24 09:08, Арсений Косицын wrote: > > Hi everyone! > > A situation has been discovered in which empty .log files are being created. > > --Reproduce: > > 1) You need to set the following parameters in the "postgresql.conf" file: > > log_destination = 'csvlog' > logging_collector = on