Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"

2024-11-20 Thread Tom Lane
"=?gb18030?B?emVuZ21hbg==?=" writes: > Thanks for your guidance, you are right, I looked at your patch > and combined it with the example to generate a new patch, > which is really better. I pushed the code fix, but I can't really convince myself that the test case is worth the cycles it'd eat fo

Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"

2024-11-19 Thread zengman
Thanks for your guidance, you are right, I looked at your patch and combined it with the example to generate a new patch, which is really better. Thanks, Man Zeng -- Original -- From:  "Tom Lane" v3-fix-incorrect-assertion.patch Description: Binary data

Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"

2024-11-19 Thread Tom Lane
"=?utf-8?B?5pu+5ruh?=" writes: > We can comment out the assertion that raises the exception, because I looked > up the code and found that the assertion doesn't seem to make a lot > of sense here. I looked at the git history and found that I added this assertion in 07b4c48b6. Your example shows

Re: [PATCH] Fixed assertion issues in "pg_get_viewdef"

2024-11-15 Thread Man Zeng
Hi everyone, The following bug has been logged on the website: Bug reference: 18710 Logged by: Man Zeng Email address: zengman(at)halodbtech(dot)com PostgreSQL version: 14.14 Operating system: centos-8 Description: A prototype of the problem from https://github.com/