Re: [PATCH] Fix small overread during SASLprep

2024-09-10 Thread Jacob Champion
On Tue, Sep 10, 2024 at 4:39 AM Daniel Gustafsson wrote: > Pushed, thanks! Thank you! --Jacob

Re: [PATCH] Fix small overread during SASLprep

2024-09-10 Thread Daniel Gustafsson
> On 9 Sep 2024, at 23:21, Daniel Gustafsson wrote: > >> On 9 Sep 2024, at 20:41, Jacob Champion >> wrote: >> >> On Mon, Sep 9, 2024 at 11:30 AM Daniel Gustafsson wrote: >>> Just to make sure I understand, this is for guarding against overreads in >>> validation of strings containing torn MB

Re: [PATCH] Fix small overread during SASLprep

2024-09-09 Thread Daniel Gustafsson
> On 9 Sep 2024, at 20:41, Jacob Champion > wrote: > > On Mon, Sep 9, 2024 at 11:30 AM Daniel Gustafsson wrote: >> Just to make sure I understand, this is for guarding against overreads in >> validation of strings containing torn MB characters? > > Right. Our SASLprep code doesn't require/enfo

Re: [PATCH] Fix small overread during SASLprep

2024-09-09 Thread Jacob Champion
On Mon, Sep 9, 2024 at 11:30 AM Daniel Gustafsson wrote: > Just to make sure I understand, this is for guarding against overreads in > validation of strings containing torn MB characters? Right. Our SASLprep code doesn't require/enforce UTF8-encoded inputs. > Assuming I didn't > misunderstand yo

Re: [PATCH] Fix small overread during SASLprep

2024-09-09 Thread Daniel Gustafsson
> On 9 Sep 2024, at 17:29, Jacob Champion > wrote: > pg_utf8_string_len() doesn't check the remaining string length before > calling pg_utf8_is_legal(), so there's a possibility of jumping a > couple of bytes past the end of the string. (The overread stops there, > because the function won't val