Re: [PATCH] Fix missing comma in Requires.private with a Make macro

On Thu, May 8, 2025 at 1:07 PM Tom Lane wrote: > I'm not aware of one, but it seems like a reasonable idea ... I've created a skeleton at https://wiki.postgresql.org/wiki/Minimum_Dependency_Versions, based on our dev documentation and some recent threads. Still plenty to fill in, if anyone knows

Re: [PATCH] Fix missing comma in Requires.private with a Make macro

Jacob Champion writes: > Is there maybe a wiki page where we gather the reasoning for our > pinned minimum versions? None of my searches turned anything up, but > it might help accelerate some of these conversations. I'm not aware of one, but it seems like a reasonable idea ...

Re: [PATCH] Fix missing comma in Requires.private with a Make macro

On Wed, May 7, 2025 at 3:39 PM Álvaro Herrera wrote: > Well, Jacob did say that he tested it with 3.81, so this patch should be > okay. Upping the minimum version can be discussed elsewhere ... or > maybe never, if we end up replacing it wholesale with Meson/ninja. To be fair, I did invite debat

Re: [PATCH] Fix missing comma in Requires.private with a Make macro

Jacob Champion writes: > On Wed, May 7, 2025 at 11:55 AM Fabrízio de Royes Mello > wrote: >> Not sure if all animals have a minimum 4.3 make version. Do you? > Oh, I doubt that very much. I don't immediately see the Make version > in the configure logs for the animals, but lapwing for example is

Re: [PATCH] Fix missing comma in Requires.private with a Make macro

On 2025-May-07, Tom Lane wrote: > Apple is still shipping > > $ which make > /usr/bin/make > > $ make --version > GNU Make 3.81 Well, Jacob did say that he tested it with 3.81, so this patch should be okay. Upping the minimum version can be discussed elsewhere ... or maybe never, if we end up

Re: [PATCH] Fix missing comma in Requires.private with a Make macro

On Wed, May 7, 2025 at 11:55 AM Fabrízio de Royes Mello wrote: > LGTM Thanks for the review! >> Tested with GNU Make 3.81 (the compilation of which was slightly >> painful; does anyone want to debate pulling that minimum version up >> sometime soon?) and 4.3. > > Not sure if all animals have a m

Re: [PATCH] Fix missing comma in Requires.private with a Make macro

On Wed, May 7, 2025 at 2:17 PM Jacob Champion < jacob.champ...@enterprisedb.com> wrote: > Hello! > > Wolfgang reported over in [1] that I've missed a comma when appending > to the PKG_CONFIG_REQUIRES_PRIVATE list, making libpq.pc look ugly: > > Requires.private: libssl, libcrypto libcurl > > p