Re: [PATCH] Fix hostaddr crash during non-blocking cancellation

2025-07-07 Thread Jacob Champion
On Thu, Jul 3, 2025 at 11:54 AM Tom Lane wrote: > I hadn't noticed (or maybe I forgot) this thread, so when the > same problem was reported at [1] I just went ahead and pushed the > submitted patch, which is only cosmetically different from your 0001. > Apologies for treading on your toes. No wor

Re: [PATCH] Fix hostaddr crash during non-blocking cancellation

2025-07-03 Thread Tom Lane
Jacob Champion writes: > A connection with only a hostaddr (no host) can't be cancelled via > PQcreateCancel(), because we'll crash in emitHostIdentityInfo(). The > problem is that the synthetic connhost entry we've created for > cancellation has an incorrect type field, which causes the following

Re: [PATCH] Fix hostaddr crash during non-blocking cancellation

2025-06-24 Thread Greg Sabino Mullane
01 looks sensible to me. I like 02 as well. Only quibble would be the name (tcp) as it doesn't really describe a class of things to be tested like the other things in PG_TEST_EXTRA. Something indicating a lack of socket? Just more verbose somehow? "tcp_only" perhaps? Cheers, Greg -- Crunchy Dat