Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 29 Nov 2024, at 19:36, Tom Lane wrote: > > David Benjamin writes: >> Thanks! I got asked about release branches, so I thought I'd pass it along: >> how do you all handle merges to release branches and would it make sense to >> merge this change? On the one hand, nothing is actively on fire

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

David Benjamin writes: > Thanks! I got asked about release branches, so I thought I'd pass it along: > how do you all handle merges to release branches and would it make sense to > merge this change? On the one hand, nothing is actively on fire yet, but > the current setup does risk breakage if Op

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

Thanks! I got asked about release branches, so I thought I'd pass it along: how do you all handle merges to release branches and would it make sense to merge this change? On the one hand, nothing is actively on fire yet, but the current setup does risk breakage if OpenSSL ever migrates BIO_s_socket

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 5 Sep 2024, at 00:10, Daniel Gustafsson wrote: > Thanks for reviewing, I plan on going ahead with this patch shortly. That ended up not being shortly, but having spent a fair bit of time reading the diff over and testing on multiple versions of OpenSSL and LibreSSL I've now pushed it. The

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 4 Sep 2024, at 23:19, David Benjamin wrote: > > On Wed, Sep 4, 2024 at 9:22 AM Daniel Gustafsson > wrote: >> > On 3 Sep 2024, at 14:18, Daniel Gustafsson > > > wrote: >> >> > Attached is a v4 rebase over the recent OpenSSL 1.0.2 removal which

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

On Wed, Sep 4, 2024 at 9:22 AM Daniel Gustafsson wrote: > > On 3 Sep 2024, at 14:18, Daniel Gustafsson wrote: > > > Attached is a v4 rebase over the recent OpenSSL 1.0.2 removal which made > this > > patch no longer apply. I've just started to dig into it so have no > comments on > > it right n

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 3 Sep 2024, at 14:18, Daniel Gustafsson wrote: > Attached is a v4 rebase over the recent OpenSSL 1.0.2 removal which made this > patch no longer apply. I've just started to dig into it so have no comments > on > it right now, but wanted to get a cleaned up version into the CFBot. CFBot bu

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 19 May 2024, at 22:32, Daniel Gustafsson wrote: > >> On 19 May 2024, at 22:21, Peter Eisentraut wrote: > >> Whoever commits these should be sure to coordinate this. > > Thanks for the reminder. I have this patchset, the OCSP stapling patchset and > the multiple-cert one on my radar for w

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 19 May 2024, at 22:21, Peter Eisentraut wrote: > Whoever commits these should be sure to coordinate this. Thanks for the reminder. I have this patchset, the OCSP stapling patchset and the multiple-cert one on my radar for when I do the 1.1.0 removal work in the July CF. Will do another sca

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

On 19.05.24 20:07, David Benjamin wrote: On Sun, May 19, 2024 at 12:21 PM Tom Lane > wrote: Per the cfbot [1], this patch needs a rebase over the ALPN-related commits.  It still isn't likely to get human attention before the July commitfest, but you can sav

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

On Sun, May 19, 2024 at 12:21 PM Tom Lane wrote: > Per the cfbot [1], this patch needs a rebase over the ALPN-related > commits. It still isn't likely to get human attention before the > July commitfest, but you can save some time by making sure it's > in a reviewable state before that. > Rebas

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

Daniel Gustafsson writes: > On 19 Apr 2024, at 15:13, David Benjamin wrote: >> Circling back here, anything else needed from my end on this patch? > Patience mostly, v17 very recently entered feature freeze so a lof of the > developers are busy finding and fixing bugs to stabilize the > release.

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 19 Apr 2024, at 15:13, David Benjamin wrote: > > Circling back here, anything else needed from my end on this patch? Patience mostly, v17 very recently entered feature freeze so a lof of the developers are busy finding and fixing bugs to stabilize the release. When the window for new featu

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

Circling back here, anything else needed from my end on this patch? On Wed, Feb 21, 2024, 17:04 David Benjamin wrote: > Thanks for the very thorough comments! I've attached a new version of the > patch. > > On Thu, Feb 15, 2024 at 4:17 PM Andres Freund wrote: > >> Hi, >> >> On 2024-02-11 13:19:

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

Thanks for the very thorough comments! I've attached a new version of the patch. On Thu, Feb 15, 2024 at 4:17 PM Andres Freund wrote: > Hi, > > On 2024-02-11 13:19:00 -0500, David Benjamin wrote: > > I've attached a patch for the master branch to fix up the custom BIOs > used > > by PostgreSQL,

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

Hi, On 2024-02-11 13:19:00 -0500, David Benjamin wrote: > I've attached a patch for the master branch to fix up the custom BIOs used > by PostgreSQL, in light of the issues with the OpenSSL update recently. > While c82207a548db47623a2bfa2447babdaa630302b9 (switching from BIO_get_data > to BIO_get_

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 15 Feb 2024, at 04:58, David Benjamin wrote: > > By the way, I'm unable to add the patch to the next commitfest due to the > cool off period for new accounts. How long is that period? I don't suppose > there's a way to avoid it? There is a way to expedite the cooling-off period (it's a SP

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

By the way, I'm unable to add the patch to the next commitfest due to the cool off period for new accounts. How long is that period? I don't suppose there's a way to avoid it? On Mon, Feb 12, 2024 at 11:31 AM David Benjamin wrote: > On Mon, Feb 12, 2024 at 9:38 AM Daniel Gustafsson wrote: > >>

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

On Mon, Feb 12, 2024 at 9:38 AM Daniel Gustafsson wrote: > > On 11 Feb 2024, at 19:19, David Benjamin wrote: > > It turns out the parts that came from the OpenSSL socket BIO were a > no-op, and in fact PostgreSQL is relying on it being a no-op. Instead, it's > cleaner to just define a custom BIO

Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions

> On 11 Feb 2024, at 19:19, David Benjamin wrote: > > Hi all, > > I've attached a patch for the master branch to fix up the custom BIOs used by > PostgreSQL, in light of the issues with the OpenSSL update recently. While > c82207a548db47623a2bfa2447babdaa630302b9 (switching from BIO_get_data t