On Thu, Sep 23, 2021 at 5:34 AM Joe Wildish wrote:
> Regarding the deparse-and-reparse --- if I understand correctly, the core
> problem is that we have no way of going from a node tree to a string, such
> that the string is guaranteed to have the same meaning as the node tree? (I
> did try jus
Joe Wildish" writes:
> On Wed, 22 Sep 2021, at 17:09, Tom Lane wrote:
> The main change is a switch to using SPI for expression evaluation. The
> plans are also cached along the same lines as the RI trigger plans.
>>
>> I really dislike this implementation technique. Aside from the likely
>> p
Hi Tom,
On Wed, 22 Sep 2021, at 17:09, Tom Lane wrote:
> > The main change is a switch to using SPI for expression evaluation. The
> > plans are also cached along the same lines as the RI trigger plans.
>
> I really dislike this implementation technique. Aside from the likely
> performance hit
"Joe Wildish" writes:
> The main change is a switch to using SPI for expression evaluation. The
> plans are also cached along the same lines as the RI trigger plans.
I really dislike this implementation technique. Aside from the likely
performance hit for existing triggers, I think it opens se
Hi Hackers,
Attached is a new version of this patch. I resurrected it after removing it
from the commitfest last year; I'll add it back in to the next CF.
The main change is a switch to using SPI for expression evaluation. The plans
are also cached along the same lines as the RI trigger plans.
Hi Surafel,
On 3 Sep 2020, at 19:22, Surafel Temesgen wrote:
This is my review of your patch
Thanks for the review.
subqueries in row trigger's is not supported in your patch so the the
documentation have to reflect it
It is still the case that the documentation says this. But, that may
On Thu, Sep 03, 2020 at 09:22:31PM +0300, Surafel Temesgen wrote:
> server crashed
That's a problem. As this feedback has not been answered after two
weeks, I am marking the patch as returned with feedback.
--
Michael
signature.asc
Description: PGP signature
Hi Joe,
This is my review of your patch
On Fri, Jul 17, 2020 at 1:22 AM Joe Wildish wrote:
> Hi hackers,
>
> Attached is a patch for supporting queries in the WHEN expression of
> statement triggers.
- Currently, WHEN expressions cannot contain
- subqueries.
subqueries in row trigger's is
> On 17 Jul 2020, at 00:22, Joe Wildish wrote:
> Attached is a patch for supporting queries in the WHEN expression of
> statement triggers.at?
Hi!,
Please create an entry for this patch in the 2020-09 commitfest to make sure
it's properly tracked:
https://commitfest.postgresql.org/29/
