Re: [PATCH] Add tab-complete for backslash commands

2021-09-08 Thread Tom Lane
"tanghy.f...@fujitsu.com" writes: > Here is the updated patch in which I added the multiple-character versions > for backslash commands > and remove their corresponding single-character version. > Of course, for backslash commands with only single-character version, no > change added. Pushed.

RE: [PATCH] Add tab-complete for backslash commands

2021-09-08 Thread tanghy.f...@fujitsu.com
On Wednesday, September 8, 2021 5:05 AM, Tom Lane wrote: >Sure, but he'd still get all the commands, just not all the possible >spellings of each one. And a person who's not sure what's available >is unlikely to be helped by an entry for "\c", because it's entirely >not clear which command that's

Re: [PATCH] Add tab-complete for backslash commands

2021-09-07 Thread Tom Lane
"tanghy.f...@fujitsu.com" writes: > On Sunday, September 5, 2021 1:42 AM, Tom Lane wrote: >> I particularly question why we'd offer both >> single- and multiple-character versions, as the single-character >> version seems entirely useless from a completion standpoint. > I generally agreed with y

RE: [PATCH] Add tab-complete for backslash commands

2021-09-05 Thread tanghy.f...@fujitsu.com
On Sunday, September 5, 2021 1:42 AM, Tom Lane wrote: >I particularly question why we'd offer both >single- and multiple-character versions, as the single-character >version seems entirely useless from a completion standpoint. I generally agreed with your opinion. But I'm not sure if there's some

Re: [PATCH] Add tab-complete for backslash commands

2021-09-04 Thread Tom Lane
... BTW, I went ahead and pushed the changes in help.c, since that part seemed uncontroversial. regards, tom lane

Re: [PATCH] Add tab-complete for backslash commands

2021-09-04 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > I've updated the commitfest entry to Ready for Committer. I was about to push this but started to have second thoughts about it. I'm not convinced that offering multiple variant spellings of the same command is really such a g

Re: [PATCH] Add tab-complete for backslash commands

2021-08-08 Thread Dagfinn Ilmari Mannsåker
"tanghy.f...@fujitsu.com" writes: > On Sunday, August 8, 2021 8:13 AM, Dagfinn Ilmari Mannsåker > wrote: >>> + "\\r", "\\rset", >> >>There's a typo here, that should be "\\reset". Also, I noticed that for >>\connect, the situation is the opposite: it has the full form but not >>the s

RE: [PATCH] Add tab-complete for backslash commands

2021-08-08 Thread tanghy.f...@fujitsu.com
On Sunday, August 8, 2021 8:13 AM, Dagfinn Ilmari Mannsåker wrote: >> +"\\r", "\\rset", > >There's a typo here, that should be "\\reset". Also, I noticed that for >\connect, the situation is the opposite: it has the full form but not >the short form (\c). > >I've addressed both in th

Re: [PATCH] Add tab-complete for backslash commands

2021-08-07 Thread Dagfinn Ilmari Mannsåker
Hi Tang, "tanghy.f...@fujitsu.com" writes: > Hi > > Attached a patch to improve the tab completion for backslash commands. > I think it’s common for some people(I'm one of them) to use full-name > commands than abbreviation. So it's more convenient if we can add the > full-name backslash comman

RE: [PATCH] Add tab-complete for backslash commands

2021-07-22 Thread tanghy.f...@fujitsu.com
On Thursday, July 15, 2021 6:46 PM, tanghy.f...@fujitsu.com wrote: >Attached a patch to improve the tab completion for backslash commands. >I think it's common for some people(I'm one of them) to use full-name commands >than abbreviation. >So it's more convenient if we can add the full-name back