Re: [PATCH] Add loongarch native checksum implementation.

On Thu, Aug 10, 2023 at 5:07 PM John Naylor wrote: > > On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier wrote: > > > > On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote: > > > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am > > > facing the below error: > > > Generatin

Re: [PATCH] Add loongarch native checksum implementation.

On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier wrote: > > On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote: > > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am > > facing the below error: > > Generating configuration headers... > > undefined symbol: USE_LOONGARCH_CRC

Re: [PATCH] Add loongarch native checksum implementation.

On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote: > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am > facing the below error: > Generating configuration headers... > undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line > 718 at ../postgresql/src/tools

Re: [PATCH] Add loongarch native checksum implementation.

On Thu, Aug 10, 2023 at 10:35 AM John Naylor wrote: > > On Tue, Aug 8, 2023 at 2:22 PM YANG Xudong wrote: > > > > On 2023/8/8 14:38, John Naylor wrote: > > > > > v4 0001 is the same as v3, but with a draft commit message. I will > > > squash and commit this week, unless there is additional feedba

Re: [PATCH] Add loongarch native checksum implementation.

On Tue, Aug 8, 2023 at 2:22 PM YANG Xudong wrote: > > On 2023/8/8 14:38, John Naylor wrote: > > > v4 0001 is the same as v3, but with a draft commit message. I will > > squash and commit this week, unless there is additional feedback. > > Looks good to me. Thanks for the additional patch. I pushe

Re: [PATCH] Add loongarch native checksum implementation.

On 2023/8/8 14:38, John Naylor wrote: It seems that platforms capable of running Postgres only support 64 bit. I think so. > So I guess using aligned memory access is necessary and I have updated > the comment in the code. Okay, so it's not "necessary" in the sense that it's illegal,

Re: [PATCH] Add loongarch native checksum implementation.

On Tue, Aug 8, 2023 at 10:07 AM YANG Xudong wrote: > On 2023/8/7 19:01, John Naylor wrote: > > The compilation test is found in c-compiler.m4, which still has all > > logic for CFLAGS_CRC, including saving and restoring the old CFLAGS. Can > > this also be simplified? > > Fixed the function in c

Re: [PATCH] Add loongarch native checksum implementation.

Thanks for the comment. I have updated the patch to v3. Please have a look. On 2023/8/7 19:01, John Naylor wrote: On Fri, Jun 16, 2023 at 8:28 AM YANG Xudong > wrote: > > +# If the intrinsics are supported, sets pgac_loongarch_crc32c_intrinsics, > > +# and CFL

Re: [PATCH] Add loongarch native checksum implementation.

On Fri, Jun 16, 2023 at 8:28 AM YANG Xudong wrote: > > +# If the intrinsics are supported, sets pgac_loongarch_crc32c_intrinsics, > > +# and CFLAGS_CRC. > > > > +# Check if __builtin_loongarch_crcc_* intrinsics can be used > > +# with the default compiler flags. > > +# CFLAGS_CRC is set if the ext

Re: [PATCH] Add loongarch native checksum implementation.

On Wed, Jul 26, 2023 at 8:25 AM YANG Xudong wrote: > > Many thanks to huchangqi. Now we have loongarch64 support for both old > world ABI and new world ABI on the buildfarm! Glad to hear it! On Wed, Jul 26, 2023 at 10:16 AM Michael Paquier wrote: > > The performance numbers presented upthread f

Re: [PATCH] Add loongarch native checksum implementation.

On 2023/7/26 11:16, Michael Paquier wrote> The performance numbers presented upthread for the CRC computations are kind of nice in this environment, but honestly I have no idea how much this architecture is used. Perhaps that's only something in China? I am not seeing much activity around that

Re: [PATCH] Add loongarch native checksum implementation.

On Wed, Jul 26, 2023 at 12:16:28PM +0900, Michael Paquier wrote: > On Wed, Jul 05, 2023 at 02:11:02PM +0700, John Naylor wrote: >> Before I look at this again: Are there any objections to another CRC >> implementation for the reason of having no buildfarm member? > > [ ... ] > > Anyway, based on

Re: [PATCH] Add loongarch native checksum implementation.

On Wed, Jul 05, 2023 at 02:11:02PM +0700, John Naylor wrote: > Also, please don't top-post (which means: quoting an entire message, with > new text at the top) -- it clutters our archives. > > Before I look at this again: Are there any objections to another CRC > implementation for the reason of h

Re: [PATCH] Add loongarch native checksum implementation.

Many thanks to huchangqi. Now we have loongarch64 support for both old world ABI and new world ABI on the buildfarm! Forwarded Message Subject: Re: [PATCH] Add loongarch native checksum implementation. Date: Tue, 25 Jul 2023 15:51:43 +0800 From: huchangqi To: YANG Xudong

Re: [PATCH] Add loongarch native checksum implementation.

Start of forwarded message From: huchangqi To: YANG Xudong Subject: Re: [PATCH] Add loongarch native checksum implementation. Date: Tue, 25 Jul 2023 15:51:43 +0800 Both cisticola and nuthatch are on the buildfarm now。 cisticola is "old worl

Re: [PATCH] Add loongarch native checksum implementation.

iated. Thanks! -Original Messages- From: "YANG Xudong" Send time:Wednesday, 07/05/2023 10:15:51 To: "John Naylor" Cc: pgsql-hackers@lists.postgresql.org, wengyanq...@ymatrix.cn, wang...@ymatrix.cn Subject: Re: [PATCH] Add loongarch native checksum implementation. I

Re: [PATCH] Add loongarch native checksum implementation.

> On 6 Jul 2023, at 09:14, huchangqi wrote: > > Hi, i have a loongarch machine runing Loongnix-server (based on > redhat/centos, it has gcc-8.3 on it), i am trying to test buildfarm on it, > when i edit build-farm.conf it seems to need animal and secret to connect the > buildfarm server. > the

Re: Re: [PATCH] Add loongarch native checksum implementation.

l-hackers@lists.postgresql.org, wengyanq...@ymatrix.cn, > wang...@ymatrix.cn > Subject: Re: [PATCH] Add loongarch native checksum implementation. > > Is there any other comment? > > If the patch looks OK, I would like to update its status to ready for > committer in the commit

Re: [PATCH] Add loongarch native checksum implementation.

On Wed, Jul 5, 2023 at 9:16 AM YANG Xudong wrote: > > Is there any other comment? It's only been a few weeks since the last patch, and this is not an urgent bugfix, so there is no reason to ping the thread. Feature freeze will likely be in April of next year. Also, please don't top-post (which m

Re: [PATCH] Add loongarch native checksum implementation.

Is there any other comment? If the patch looks OK, I would like to update its status to ready for committer in the commitfest. Thanks! On 2023/6/16 09:28, YANG Xudong wrote: Updated the patch based on the comments. On 2023/6/15 18:30, John Naylor wrote: On Wed, Jun 14, 2023 at 9:20 AM YAN

Re: [PATCH] Add loongarch native checksum implementation.

Updated the patch based on the comments. On 2023/6/15 18:30, John Naylor wrote: On Wed, Jun 14, 2023 at 9:20 AM YANG Xudong > wrote: > > Attached a new patch with fixes based on the comment below. Note: It's helpful to pass "-v" to git format-patch, to have dif

Re: [PATCH] Add loongarch native checksum implementation.

On Wed, Jun 14, 2023 at 9:20 AM YANG Xudong wrote: > > Attached a new patch with fixes based on the comment below. Note: It's helpful to pass "-v" to git format-patch, to have different versions. > > For x86 and Arm, if it fails to link without an -march flag, we allow > > for a runtime check. T

Re: [PATCH] Add loongarch native checksum implementation.

Attached a new patch with fixes based on the comment below. On 2023/6/13 18:26, John Naylor wrote: On Thu, Jun 8, 2023 at 12:24 PM YANG Xudong > wrote: > > This patch tries to add loongarch native crc32 check with crcc.* > instructions to postgresql. > > The

Re: [PATCH] Add loongarch native checksum implementation.

On Thu, Jun 8, 2023 at 12:24 PM YANG Xudong wrote: > > This patch tries to add loongarch native crc32 check with crcc.* > instructions to postgresql. > > The patch is tested on my Loongson 3A5000 machine with Loong Arch Linux > and GCC 13.1.0 / clang 16.0.0 with > > - default ./configure > - defau