Re: [PATCH] Add an ldflags_sl meson build option

2025-06-18 Thread Peter Eisentraut
On 18.06.25 08:40, Matt Smith (matts3) wrote: Yes I understand what you're saying. I know Meson tries to set some of these flags. But I want the source of truth for my flags for each target type to be outside Meson.  Which Meson is not designed to do. When you're building many 3^rd  party deps

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-17 Thread Matt Smith (matts3)
s. If you don't mind me asking - I assume ldflags_sl exists as a way for postgres internally to be able to set flags across all shared libs? From: Peter Eisentraut Sent: Wednesday, June 18, 2025 3:34 PM To: Matt Smith (matts3) ; pgsql-hack...@post

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-17 Thread Peter Eisentraut
On 18.06.25 03:11, Matt Smith (matts3) wrote: An example of a shared library-specific flag is -shared on linux or - dynamiclib on darwin. But those options are already added by the build system itself. LDFLAGS_SL would be if you wanted to pass some additional custom linker flag just for share

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-17 Thread Matt Smith (matts3)
An example of a shared library-specific flag is -shared on linux or -dynamiclib on darwin. From: Peter Eisentraut Sent: Tuesday, June 17, 2025 7:01 PM To: Matt Smith (matts3) ; pgsql-hack...@postgresql.org Subject: Re: [PATCH] Add an ldflags_sl meson build

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-17 Thread Peter Eisentraut
On 17.06.25 00:50, Matt Smith (matts3) wrote: I have a Bazel toolchain that sets different linker flags for exe/shared lib. I wanted to build postgresql shared libs with meson using the same toolchain flags that I build all my other 3rd party deps in Bazel. Currently for postgresql builds, w

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-17 Thread Matt Smith (matts3)
Updated patch with new description From: Nazir Bilal Yavuz Sent: Tuesday, June 17, 2025 6:05 PM To: Matt Smith (matts3) Cc: pgsql-hack...@postgresql.org Subject: Re: [PATCH] Add an ldflags_sl meson build option Hi, On Mon, 16 Jun 2025 at 14:26, Matt Smith

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-17 Thread Nazir Bilal Yavuz
Hi, On Mon, 16 Jun 2025 at 14:26, Matt Smith (matts3) wrote: > > Currently there doesn't seem to be a way to pass shared library-specific > flags via a meson build option. > > This patch allows the existing ldflags_sl to be set via a build option. > > Patch created against the 17.4 release. The

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-16 Thread Matt Smith (matts3)
2025 9:32 PM To: Matt Smith (matts3) ; pgsql-hack...@postgresql.org Subject: Re: [PATCH] Add an ldflags_sl meson build option On 16.06.25 06:10, Matt Smith (matts3) wrote: > Currently there doesn't seem to be a way to pass shared library-specific > flags via a meson build option

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-16 Thread Peter Eisentraut
On 16.06.25 06:10, Matt Smith (matts3) wrote: Currently there doesn't seem to be a way to pass shared library-specific flags via a meson build option. This patch allows the existing ldflags_sl to be set via a build option. What uses do you have in mind for this?