Re: [PATCH] ALTER TABLE ... SET STORAGE default

2022-11-10 Thread Tom Lane
I wrote: > I've not read the patch in any detail, but I don't see a problem > with the design. Hearing no push-back on that position, I reviewed and pushed the patch. You'd missed that it also affects CREATE TABLE, but otherwise it was in pretty good shape. regards, tom l

Re: [PATCH] ALTER TABLE ... SET STORAGE default

2022-11-05 Thread Tom Lane
Aleksander Alekseev writes: > Hi Nikita, >> This seems a little bit confusing and thus very unfriendly for the user, >> because the actual meaning >> of the same 'DEFAULT' option will be different for each data type, and to >> check storage mode user >> has to query full table (or column) descri

Re: [PATCH] ALTER TABLE ... SET STORAGE default

2022-08-22 Thread Nikita Malakhov
Hi! Anyway, adding a paragraph with default storage mode for each standard data type seems like a good idea and I'd prepare a patch for it. Thank you! On Mon, Aug 22, 2022 at 4:28 PM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi Nikita, > > > This seems a little bit confusing and t

Re: [PATCH] ALTER TABLE ... SET STORAGE default

2022-08-22 Thread Aleksander Alekseev
Hi Nikita, > This seems a little bit confusing and thus very unfriendly for the user, > because the actual meaning > of the same 'DEFAULT' option will be different for each data type, and to > check storage mode user > has to query full table (or column) description. > I'd rather add a paragraph

Re: [PATCH] ALTER TABLE ... SET STORAGE default

2022-08-22 Thread Nikita Malakhov
Hi hackers! This seems a little bit confusing and thus very unfriendly for the user, because the actual meaning of the same 'DEFAULT' option will be different for each data type, and to check storage mode user has to query full table (or column) description. I'd rather add a paragraph in documenta