Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-12-19 Thread Peter Eisentraut
On 11/29/17 19:59, Michael Paquier wrote: > On Wed, Nov 29, 2017 at 1:53 PM, Michael Paquier > wrote: >> On Wed, Nov 29, 2017 at 8:12 AM, Tom Lane wrote: >>> IIRC, this issue was debated at great length back when we first put >>> in foreign tables, because early drafts of postgres_fdw did what yo

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-29 Thread Michael Paquier
On Wed, Nov 29, 2017 at 1:53 PM, Michael Paquier wrote: > On Wed, Nov 29, 2017 at 8:12 AM, Tom Lane wrote: >> IIRC, this issue was debated at great length back when we first put >> in foreign tables, because early drafts of postgres_fdw did what you >> propose here, and we ran into very nasty pro

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 8:12 AM, Tom Lane wrote: > IIRC, this issue was debated at great length back when we first put > in foreign tables, because early drafts of postgres_fdw did what you > propose here, and we ran into very nasty problems. We eventually decided > that allowing remotely-determi

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-28 Thread Tom Lane
Peter Eisentraut writes: > I've been playing with a few test cases and I'm a bit confused by how > some of this is supposed to work. AFAICT, in the SQL standard, foreign > tables can't have column defaults, but in PostgreSQL it's allowed. This > creates some semantic differences, I think. For e

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-28 Thread Peter Eisentraut
On 11/3/17 07:53, Michael Paquier wrote: > Trying to insert some data using OVERRIDING SYSTEM VALUE on a foreign > table with a remote relation defined with GENERATED ALWAYS would just > fail: > =# insert into id_always_foreign OVERRIDING system VALUE values (8); > ERROR: 428C9: cannot insert into