Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

2018-01-03 Thread Tom Lane
Dmitry Dolgov <9erthali...@gmail.com> writes: > Oh, ok - I see now, thank you. So, I think no one would object if I'll mark > this patch as ready for committer. Pushed, thanks for reviewing! regards, tom lane

Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

2018-01-03 Thread Dmitry Dolgov
> On 2 January 2018 at 20:52, Tom Lane wrote: > > I did find one case where the patch makes things significantly slower: > > select * from test where true is true > and true is true > and true is true > and true is true > ... (100 times altogether) Yes, indeed, I never tested this kind of con

Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

2018-01-02 Thread Tom Lane
Dmitry Dolgov <9erthali...@gmail.com> writes: > I tried to experiment a bit with this patch, hope it may be helpful. Thanks for reviewing! I took your idea of just running pgbench results, and adapted it to these test cases: select * from test where 1 = 1 or 1 = 2; select * from test where 1 =

Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

2017-12-13 Thread Dmitry Dolgov
> On 12 September 2017 at 15:29, Tom Lane wrote: > > This patch no longer applies cleanly on HEAD, so here's a rebased version > (no substantive changes). As before, I think the most useful review task > would be to quantify whether it makes planning noticeably slower. I tried to experiment a bi

Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

2017-11-29 Thread Michael Paquier
On Mon, Oct 2, 2017 at 7:52 AM, Tom Lane wrote: > I wrote: >> This patch no longer applies cleanly on HEAD, so here's a rebased version >> (no substantive changes). As before, I think the most useful review task >> would be to quantify whether it makes planning noticeably slower. > > Rebased agai