Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2018-01-31 Thread Michael Paquier
On Mon, Jan 22, 2018 at 03:12:58PM -0500, Stephen Frost wrote: > I would think the next step here, as Michael suggested very early on in > this thread, would be to bring the exclude list and perhaps logic for > pg_basebackup into the common code and have pg_rewind leverage that > instead of having

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2018-01-22 Thread Stephen Frost
Chris, * Chris Travers (chris.trav...@adjust.com) wrote: > Attached is the patch as submitted for commitfest. This has been stuck in Waiting for Author since before the commitfest started. I'll try to kick-start it but it seems like it's stuck because there's a fundamental disagreement about if

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2017-11-29 Thread David Steele
On 11/29/17 12:46 AM, Michael Paquier wrote:> On Wed, Nov 1, 2017 at 5:58 PM, Chris Travers wrote: > > Please note that I am still -1 for using a methodology different than > what is used for base backups with an inclusive method, and would much > prefer an exclusive method by reusing the existing

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2017-11-28 Thread Michael Paquier
On Wed, Nov 1, 2017 at 5:58 PM, Chris Travers wrote: > I would also like to address a couple of important points here: > > 1. I think default restrictions plus additional paths is the best, safest > way forward. Excluding shell-globs doesn't solve the "I need this > particular config file" very