Re: [HACKERS] Fix number skipping in to_number

2018-10-22 Thread Ioseph Kim
Hi. I'm checking release note for version 11. in that. |"L| and |TH| now only consume characters that are not digits, positive/negative signs, decimal points, or commas." postgres@postgres=# select to_number('1234', '+');  to_number ---    234 Is this right? Regards, ios

Re: [HACKERS] Fix number skipping in to_number

2017-11-13 Thread Tom Lane
Oliver Ford writes: > On Sun, Nov 12, 2017 at 7:00 PM, Tom Lane wrote: >> * Don't we need to fix the NUM_L (currency symbol) case in the >> same manner? (The NUM_D and NUM_S cases are handled in >> NUM_numpart_from_char and seem ok at a quick glance.) > Yes you get the same skipping if you do:

Re: [HACKERS] Fix number skipping in to_number

2017-11-13 Thread Oliver Ford
On Sun, Nov 12, 2017 at 7:00 PM, Tom Lane wrote: > Oliver Ford writes: >> [ 0001-apply-number-v3.patch ] > > I looked at this patch briefly and have a couple of comments: > > * It seems entirely wrong to be matching to L_thousands_sep in the > NUM_COMMA case; that format code is by definition not