Re: [HACKERS] A weird bit in pg_upgrade/exec.c

2017-11-16 Thread Tom Lane
a.akent...@postgrespro.ru writes: > I see this bug is now fixed in pg_upgrade/exec.c => check_bin_dir(). > There's another bit exactly like that in check_data_dir() though. Oh, so there is ... and looking around, that seems to have been copied-and-pasted out of check_cluster_versions(), without a

Re: [HACKERS] A weird bit in pg_upgrade/exec.c

2017-11-16 Thread a . akenteva
Tom Lane writes: Yeah, the way it is now seems outright broken. It will try to do get_bin_version on the new cluster before having done validate_exec there, violating its own comment. I think we should change this as a bug fix, independently of whatever else you had in mind to do here. I see