Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2019-01-31 Thread Andres Freund
Hi, On 2018-11-29 19:04:24 +0100, Dmitry Dolgov wrote: > > On Tue, Oct 2, 2018 at 7:43 AM Michael Paquier wrote: > > > > On Thu, Jul 12, 2018 at 03:07:33PM -0400, Robbie Harwood wrote: > > > This patch looks good to me. +1; Álvaro, please update the CF entry > > > when you're also satisfied. > >

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-11-29 Thread Dmitry Dolgov
> On Tue, Oct 2, 2018 at 7:43 AM Michael Paquier wrote: > > On Thu, Jul 12, 2018 at 03:07:33PM -0400, Robbie Harwood wrote: > > This patch looks good to me. +1; Álvaro, please update the CF entry > > when you're also satisfied. > > The patch set does not apply anymore, so I have moved it to next

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-10-01 Thread Michael Paquier
On Thu, Jul 12, 2018 at 03:07:33PM -0400, Robbie Harwood wrote: > This patch looks good to me. +1; Álvaro, please update the CF entry > when you're also satisfied. The patch set does not apply anymore, so I have moved it to next CF, waiting on author. -- Michael signature.asc Description: PGP s

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-12 Thread Robbie Harwood
Nico Williams writes: > Attached is an additional patch, as well as a new, rebased patch. > > This includes changes responsive to Álvaro Herrera's commentary about > the SET CONSTRAINTS manual page. This patch looks good to me. +1; Álvaro, please update the CF entry when you're also satisfied.

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-11 Thread Nico Williams
Attached is an additional patch, as well as a new, rebased patch. This includes changes responsive to Álvaro Herrera's commentary about the SET CONSTRAINTS manual page. Nico -- >From e7838b60dbf0a8cd7f35591db2f9aab78d8903cb Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Wed, 11 Jul 2018

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-11 Thread Nico Williams
On Wed, Jul 11, 2018 at 01:41:12PM -0500, Nico Williams wrote: > > > @@ -5538,17 +5568,24 @@ ConstraintAttributeSpec: > > > int newspec = $1 | $2; > > > > > > /* special message for this case */ > > > -

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-11 Thread Nico Williams
On Wed, Jul 11, 2018 at 03:13:30PM -0400, Alvaro Herrera wrote: > On 2018-Jun-06, Nico Williams wrote: > > I've finally gotten around to rebasing this patch and making the change > > that was requested, which was: merge the now-would-be-three deferral- > > related bool columns in various pg_catalog

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-11 Thread Alvaro Herrera
On 2018-Jun-06, Nico Williams wrote: > I've finally gotten around to rebasing this patch and making the change > that was requested, which was: merge the now-would-be-three deferral- > related bool columns in various pg_catalog tables into one char column. > > Instead of (deferrable, initdeferred

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-11 Thread Nico Williams
On Tue, Jun 26, 2018 at 04:54:13PM -0400, Robbie Harwood wrote: > Nico Williams writes: > > > [Re-send; first attempt appears to have hit /dev/null somewhere. My > > apologies if you get two copies.] > > > > I've finally gotten around to rebasing this patch and making the change > > that was req

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-07-02 Thread Nico Williams
On Tue, Jun 26, 2018 at 04:54:13PM -0400, Robbie Harwood wrote: > Nico Williams writes: > > > [Re-send; first attempt appears to have hit /dev/null somewhere. My > > apologies if you get two copies.] > > > > I've finally gotten around to rebasing this patch and making the change > > that was req

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-06-26 Thread Robbie Harwood
Nico Williams writes: > [Re-send; first attempt appears to have hit /dev/null somewhere. My > apologies if you get two copies.] > > I've finally gotten around to rebasing this patch and making the change > that was requested, which was: merge the now-would-be-three deferral- > related bool colum

Re: [HACKERS] [PATCH] WIP Add ALWAYS DEFERRED option for constraints

2018-06-06 Thread Nico Williams
[Re-send; first attempt appears to have hit /dev/null somewhere. My apologies if you get two copies.] I've finally gotten around to rebasing this patch and making the change that was requested, which was: merge the now-would-be-three deferral- related bool columns in various pg_catalog tables int