Re: [GSoC] working status

2018-07-09 Thread Charles Cui
yes, my CI test version is 9.4. will make it work on 10 by following your advices. Thanks. On Mon, Jul 9, 2018, 5:22 AM Aleksander Alekseeev wrote: > Hello Charles, > > > > ``` > > > pg_thrift.c:1313:26: error: too few arguments to function > > > ‘array_create_iterator’ ArrayIterator iter = > >

Re: [GSoC] working status

2018-07-09 Thread Aleksander Alekseeev
Hello Charles, > > ``` > > pg_thrift.c:1313:26: error: too few arguments to function > > ‘array_create_iterator’ ArrayIterator iter = > > array_create_iterator(parray, 0); ^ > > In file included from pg_thrift.c:5: > > .../postgresql-install/include/server/utils/array.h:418:22

Re: [GSoC] working status

2018-07-09 Thread Aleksander Alekseeev
Hello Charles, > ``` > pg_thrift.c:1313:26: error: too few arguments to function > ‘array_create_iterator’ ArrayIterator iter = > array_create_iterator(parray, 0); ^ > In file included from pg_thrift.c:5: > .../postgresql-install/include/server/utils/array.h:418:22: > note: dec

Re: [GSoC] working status

2018-07-09 Thread Aleksander Alekseeev
Hello Charles, >The second review is coming. Here is my working status so far. 1. > Complete the thrift compact protocol implementation using bytea > interface. 2. Thrift type (binary protocol) is almost done, the only > remaining part is struct encoding and decoding. With the thrift type, > y

Re: [GSoC] working status

2018-06-26 Thread Charles Cui
got it, will start to use these tools and add more comments. On Tue, Jun 26, 2018, 7:44 AM Aleksander Alekseeev < a.aleks...@postgrespro.ru> wrote: > Hello Charles, > > >Here is my current working status. Resolved all warnings found by > > Aleksander previously. Having two threads in parallel

Re: [GSoC] working status

2018-06-26 Thread Aleksander Alekseeev
Hello Charles, >Here is my current working status. Resolved all warnings found by > Aleksander previously. Having two threads in parallel. One is the > thrift binary type implementation, the other is thrift compact byte > interface implementation. For these two threads, simple data type has >