Re: 'make check' fails

2018-04-11 Thread Bruce Momjian
On Wed, Apr 11, 2018 at 01:04:56PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote: > >> We can fix this by making submake-generated-headers be a recursive > >> prerequisite for "check" as well as "all" and "install". I wonder > >> wheth

Re: 'make check' fails

2018-04-11 Thread Tom Lane
Bruce Momjian writes: > On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote: >> We can fix this by making submake-generated-headers be a recursive >> prerequisite for "check" as well as "all" and "install". I wonder >> whether anybody is expecting any other shortcuts to work. > In case it w

Re: 'make check' fails

2018-04-11 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> We can fix this by making submake-generated-headers be a recursive >> prerequisite for "check" as well as "all" and "install". I wonder >> whether anybody is expecting any other shortcuts to work. > check-world certainly, but presumably that depends on

Re: 'make check' fails

2018-04-11 Thread Alvaro Herrera
Tom Lane wrote: > We can fix this by making submake-generated-headers be a recursive > prerequisite for "check" as well as "all" and "install". I wonder > whether anybody is expecting any other shortcuts to work. check-world certainly, but presumably that depends on check? -- Álvaro Herrera

Re: 'make check' fails

2018-04-11 Thread Bruce Momjian
On Wed, Apr 11, 2018 at 12:35:41PM -0400, Tom Lane wrote: > Andrew Gierth writes: > > Tom> Please be more explicit about what state you're starting from. > > > This is consistently failing for me, on FreeBSD with GNU Make 4.2.1, > > clang 3.9.1, at commit 651cb90941: > > > git clean -dfx > > ./

Re: 'make check' fails

2018-04-11 Thread Tom Lane
Andrew Gierth writes: > Tom> Please be more explicit about what state you're starting from. > This is consistently failing for me, on FreeBSD with GNU Make 4.2.1, > clang 3.9.1, at commit 651cb90941: > git clean -dfx > ./configure '--prefix=/home/andrew/work/pgsql/head' \ > '--with-includes=/u

Re: 'make check' fails

2018-04-11 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> No doubt this is related to the generated-headers changes I've Tom> been making, but I find your recipe confusing. "make clean" should Tom> not have removed the generated headers from the previous build. I Tom> can believe that if you started from a bare g

Re: 'make check' fails

2018-04-11 Thread Bruce Momjian
On Wed, Apr 11, 2018 at 10:59:45AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have discovered that: > > make clean; make check > > fails with: > > No doubt this is related to the generated-headers changes I've been > making, but I find your recipe confusing. "make clean" should not

Re: 'make check' fails

2018-04-11 Thread Tom Lane
Bruce Momjian writes: > I have discovered that: > make clean; make check > fails with: No doubt this is related to the generated-headers changes I've been making, but I find your recipe confusing. "make clean" should not have removed the generated headers from the previous build. I can be