Re: Random subscription 021_twophase test failure on kestrel

2025-05-26 Thread vignesh C
On Mon, 26 May 2025 at 13:59, Michael Paquier wrote: > > On Sat, May 24, 2025 at 11:27:05AM +0530, Amit Kapila wrote: > > On Sat, May 24, 2025 at 6:07 AM Michael Paquier wrote: > >> Yes, agreed that your suggested fix looks sensible with an extra check > >> for pg_prepared_xacts on the subscriber

Re: Random subscription 021_twophase test failure on kestrel

2025-05-26 Thread Michael Paquier
On Sat, May 24, 2025 at 11:27:05AM +0530, Amit Kapila wrote: > On Sat, May 24, 2025 at 6:07 AM Michael Paquier wrote: >> Yes, agreed that your suggested fix looks sensible with an extra check >> for pg_prepared_xacts on the subscriber side that can be useful for >> debugging. > > +1. Applied dow

Re: Random subscription 021_twophase test failure on kestrel

2025-05-23 Thread Amit Kapila
On Sat, May 24, 2025 at 6:07 AM Michael Paquier wrote: > > > Yes, agreed that your suggested fix looks sensible with an extra check > for pg_prepared_xacts on the subscriber side that can be useful for > debugging. > +1. -- With Regards, Amit Kapila.

Re: Random subscription 021_twophase test failure on kestrel

2025-05-23 Thread Michael Paquier
On Fri, May 23, 2025 at 08:55:27PM +0530, vignesh C wrote: > This issue can be consistently reproduced by injecting a delay (e.g., > 3 seconds) in tap_sub's walsender while decoding the commit of > 'mygid'. A patch to demonstrate this behavior is provided at > 021_two_phase_test_failure_reproduce.p

Random subscription 021_twophase test failure on kestrel

2025-05-23 Thread vignesh C
Hi, The 021_twophase test has failed on Kestrel at [1] with the following error: # Failed test 'should be no prepared transactions on subscriber' # at /home/bf/bf-build/kestrel/HEAD/pgsql/src/test/subscription/t/021_twophase.pl line 438. # got: '1' # expected: '0' # Looks like yo