Re: Race condition in server-crash testing

2022-04-05 Thread Tom Lane
Andres Freund writes: > On 2022-04-04 00:50:27 -0400, Tom Lane wrote: >> It's hard to be totally sure, but I think what happened is that >> gaur hit the in-hindsight-obvious race condition in this code: >> we managed to execute a successful iteration of poll_query_until >> before the postmaster ha

Re: Race condition in server-crash testing

2022-04-03 Thread Noah Misch
On Sun, Apr 03, 2022 at 10:07:21PM -0700, Andres Freund wrote: > On 2022-04-04 00:50:27 -0400, Tom Lane wrote: > > My pet dinosaur gaur just failed [1] in > > src/test/recovery/t/022_crash_temp_files.pl, which does this: > > > > - > > my $ret = PostgreSQL::Test::Utils::system_log('pg_ctl', 'ki

Re: Race condition in server-crash testing

2022-04-03 Thread Andres Freund
Hi, On 2022-04-04 00:50:27 -0400, Tom Lane wrote: > My pet dinosaur gaur just failed [1] in > src/test/recovery/t/022_crash_temp_files.pl, which does this: > > - > my $ret = PostgreSQL::Test::Utils::system_log('pg_ctl', 'kill', 'KILL', $pid); > is($ret, 0, 'killed process with KILL'); > > #

Race condition in server-crash testing

2022-04-03 Thread Tom Lane
My pet dinosaur gaur just failed [1] in src/test/recovery/t/022_crash_temp_files.pl, which does this: - my $ret = PostgreSQL::Test::Utils::system_log('pg_ctl', 'kill', 'KILL', $pid); is($ret, 0, 'killed process with KILL'); # Close psql session $killme->finish; $killme2->finish; # Wait till