Re: RFC: Table access methods and scans

2021-06-11 Thread Andres Freund
Hi, On 2021-06-03 17:52:24 -0700, Jeff Davis wrote: > I agree that would be very conventient for non-heap AMs. There's a very > old commit[3] that says: > > + /* > +* Note that unlike IndexScan, SeqScan never use keys > +* in heap_beginscan (and this is very bad) - so, here >

Re: RFC: Table access methods and scans

2021-06-04 Thread Jeff Davis
On Fri, 2021-06-04 at 08:23 +0200, Mats Kindahl wrote: > That is basically the question. I'm prepared to take a shot at it > unless there is a good reason not to. Sounds good, I can review. Regards, Jeff Davis

Re: RFC: Table access methods and scans

2021-06-03 Thread Mats Kindahl
Hi Jeff, On Fri, Jun 4, 2021 at 2:52 AM Jeff Davis wrote: > Hi, > > On Wed, 2021-03-31 at 22:10 +0200, Mats Kindahl wrote: > > As an example of how this is useful, I noticed the work by Heikki and > > Ashwin [1], where they return a `TableScanDesc` that contains > > information about what column

Re: RFC: Table access methods and scans

2021-06-03 Thread Jeff Davis
Hi, On Wed, 2021-03-31 at 22:10 +0200, Mats Kindahl wrote: > As an example of how this is useful, I noticed the work by Heikki and > Ashwin [1], where they return a `TableScanDesc` that contains > information about what columns to scan, which looks very useful. > Since > the function `table_begins

RFC: Table access methods and scans

2021-03-31 Thread Mats Kindahl
Hi all, I started looking into how table scans are handled for table access methods and have discovered a few things that I find odd. I cannot find any material regarding why this particular choice was made (if anybody has pointers, I would be very grateful). I am quite new to PostgreSQL so forgi