Re: REINDEX and shared catalogs

2018-08-09 Thread Michael Paquier
On Wed, Aug 08, 2018 at 07:36:22PM +, Bossart, Nathan wrote: > On 8/8/18, 2:16 PM, "Michael Paquier" wrote: >> By no-backpatch, I only implied patching v12, but that would not be a >> huge amount of efforts to get that into v11, so I can do that as well. >> Any objections to doing that? > > +

Re: REINDEX and shared catalogs

2018-08-08 Thread Bossart, Nathan
On 8/8/18, 2:16 PM, "Michael Paquier" wrote: > By no-backpatch, I only implied patching v12, but that would not be a > huge amount of efforts to get that into v11, so I can do that as well. > Any objections to doing that? +1 for back-patching to v11. Nathan

Re: REINDEX and shared catalogs

2018-08-08 Thread Michael Paquier
On Wed, Aug 08, 2018 at 02:39:00PM -0400, Tom Lane wrote: > Alvaro Herrera writes: >> I agree that it would be good to have it fixed in released versions, but >> I also agree that such a change could cause trouble in production for >> some. Is the "no backpatch" idea that you will push this to bo

Re: REINDEX and shared catalogs

2018-08-08 Thread Tom Lane
Alvaro Herrera writes: > On 2018-Aug-05, Michael Paquier wrote: >> Attached is a set of patches I proposed on the original thread, which >> skips shared catalogs if the user running REINDEX is not an owner of >> it. This is a behavior change, and as I have a hard time believing that >> anybody ca

Re: REINDEX and shared catalogs

2018-08-08 Thread Alvaro Herrera
On 2018-Aug-05, Michael Paquier wrote: > Attached is a set of patches I proposed on the original thread, which > skips shared catalogs if the user running REINDEX is not an owner of > it. This is a behavior change, and as I have a hard time believing that > anybody can take advantage of the curre

Re: REINDEX and shared catalogs

2018-08-08 Thread Michael Paquier
On Wed, Aug 08, 2018 at 12:25:03PM +0530, Robert Haas wrote: > In my opinion, the behavior change is probably OK, but not > back-patchable. Thanks. I see three votes in favor of not back-patching (you, Horiguchi-san and Nathan), so that won't happen. > I think that the documentation could be phr

Re: REINDEX and shared catalogs

2018-08-07 Thread Robert Haas
On Mon, Aug 6, 2018 at 2:40 AM, Michael Paquier wrote: > In the case of REINDEX, we *allow* shared catalogs to be reindexed. > Hence, if a user is a database owner, he would also be able to reindex > critical indexes on shared catalogs, where blocking authentication is > possible just with session

Re: REINDEX and shared catalogs

2018-08-05 Thread Bossart, Nathan
On 8/5/18, 4:12 PM, "Michael Paquier" wrote: > Attached is a set of patches I proposed on the original thread, which > skips shared catalogs if the user running REINDEX is not an owner of > it. This is a behavior change, and as I have a hard time believing that > anybody can take advantage of the

REINDEX and shared catalogs

2018-08-05 Thread Michael Paquier
Hi all, This is a continuation of the thread "Canceling authentication due to timeout aka Denial of Service Attack", which is here to focus on the case of REINDEX: https://www.postgresql.org/message-id/20180730003422.GA2878%40paquier.xyz As visibly the set of patches I proposed on this thread is