RE: doc patch: clarify the naming rule for injection_points

2025-04-21 Thread Hayato Kuroda (Fujitsu)
Dear Michael, > Thanks, I've applied some slight tweaks, and applied the result down > to v17, leaving the heap_update point alone. Thanks, I confirmed your commit on HEAD and LGTM. Best regards, Hayato Kuroda FUJITSU LIMITED

Re: doc patch: clarify the naming rule for injection_points

2025-04-21 Thread Michael Paquier
On Mon, Apr 21, 2025 at 12:10:51PM +, Hayato Kuroda (Fujitsu) wrote: > Thanks for suggesting them. ISTM, you are correct. PSA updated version. Thanks, I've applied some slight tweaks, and applied the result down to v17, leaving the heap_update point alone. -- Michael signature.asc Descriptio

RE: doc patch: clarify the naming rule for injection_points

2025-04-21 Thread Hayato Kuroda (Fujitsu)
Dear Michael, > > I also feel just converting lower case is not good. The point seems to > > locate in > > the end-of-transaction callback and it accepts invalidation messages. Based > > on > the > > fact, how about "inval-process-invalidation-messages"? > > 0002 did simple replacements of these

Re: doc patch: clarify the naming rule for injection_points

2025-04-21 Thread Michael Paquier
On Mon, Apr 14, 2025 at 12:36:20PM +, Hayato Kuroda (Fujitsu) wrote: > I also feel just converting lower case is not good. The point seems to locate > in > the end-of-transaction callback and it accepts invalidation messages. Based > on the > fact, how about "inval-process-invalidation-messag

RE: doc patch: clarify the naming rule for injection_points

2025-04-14 Thread Hayato Kuroda (Fujitsu)
Dear Aleksander, > ``` > - their own code using the same macro. > + their own code using the same macro. The name of injection points must > be > + lower characters, and dashes must separate its terms. > ``` > > Perhaps "must" is a too strong statement. I suggest something like: >

Re: doc patch: clarify the naming rule for injection_points

2025-04-14 Thread Aleksander Alekseev
Hi, > Naming rule of points is not determined yet, but most of them have lower cases > and each term are divided by dash "-". I think this is a good chance to > formally > clarify it. PSA adding the description. > > I was confused the correct place for the description. I added at the end of > fi