Re: create subscription with (origin = none, copy_data = on)

2025-01-29 Thread Shlok Kyal
On Wed, 29 Jan 2025 at 15:58, vignesh C wrote: > > On Fri, 24 Jan 2025 at 09:52, Shlok Kyal wrote: > > > > I have added the test in the latest patch. > > Few comments: > 1) Let's rearrange this query slightly so that the "PT.pubname IN > ()" appears at the end, the reason being that it

Re: create subscription with (origin = none, copy_data = on)

2025-01-29 Thread vignesh C
On Fri, 24 Jan 2025 at 09:52, Shlok Kyal wrote: > > I have added the test in the latest patch. Few comments: 1) Let's rearrange this query slightly so that the "PT.pubname IN ()" appears at the end, the reason being that it will be easy to copy/paste and edit it to include the publicat

Re: create subscription with (origin = none, copy_data = on)

2025-01-28 Thread Sergey Tatarintsev
23.01.2025 09:46, Amit Kapila пишет: On Wed, Jan 22, 2025 at 9:44 PM Sergey Tatarintsev wrote: 22.01.2025 18:41, Shlok Kyal пишет: Also we still don't care about foreign partitions (as I wrote earlier we should raise an ERROR for such publications). I think dealing with this separately from

Re: create subscription with (origin = none, copy_data = on)

2025-01-27 Thread Amit Kapila
On Fri, Jan 24, 2025 at 5:43 PM Sergey Tatarintsev wrote: > > I think there is another problem - publisher can modify publication > during the execution of "CREATE SUBSCRIPTION" (Rarely, this situation > occurred in my tests.) > > I.e.: > > 1. Publisher: CREATE PUBLICATION ... FOR TABLE t1; > > 2.

Re: create subscription with (origin = none, copy_data = on)

2025-01-24 Thread Sergey Tatarintsev
24.01.2025 07:22, Shlok Kyal пишет: On Thu, 23 Jan 2025 at 17:54, Zhijie Hou (Fujitsu) wrote: On Thursday, January 23, 2025 4:43 PM Shlok Kyal wrote: On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: Thanks for the patch. I agree

Re: create subscription with (origin = none, copy_data = on)

2025-01-23 Thread Shlok Kyal
On Thu, 23 Jan 2025 at 17:54, Zhijie Hou (Fujitsu) wrote: > > On Thursday, January 23, 2025 4:43 PM Shlok Kyal > wrote: > > > > On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: > > > > > > On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) > > > wrote: > > > > > > > > Thanks for the patch. > >

Re: create subscription with (origin = none, copy_data = on)

2025-01-23 Thread Sergey Tatarintsev
23.01.2025 15:24, Zhijie Hou (Fujitsu) пишет: On Thursday, January 23, 2025 4:43 PM Shlok Kyal wrote: On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: Thanks for the patch. I agree that covering the partitioned table case when che

RE: create subscription with (origin = none, copy_data = on)

2025-01-23 Thread Zhijie Hou (Fujitsu)
On Thursday, January 23, 2025 4:43 PM Shlok Kyal wrote: > > On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: > > > > On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) > > wrote: > > > > > > Thanks for the patch. > > > > > > I agree that covering the partitioned table case when checking the > >

Re: create subscription with (origin = none, copy_data = on)

2025-01-23 Thread Shlok Kyal
On Thu, 23 Jan 2025 at 12:35, Shlok Kyal wrote: > > On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) > wrote: > > > > On Tuesday, January 21, 2025 1:31 AM vignesh C wrote: > > > > Hi, > > > > > > > > On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: > > > > > > > > On Sat, Jan 18, 2025 at 10:3

Re: create subscription with (origin = none, copy_data = on)

2025-01-22 Thread Shlok Kyal
On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: > > On Tuesday, January 21, 2025 1:31 AM vignesh C wrote: > > Hi, > > > > > On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: > > > > > > On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: > > > > > > > > Attached patch has the fix for thi

Re: create subscription with (origin = none, copy_data = on)

2025-01-22 Thread Amit Kapila
On Wed, Jan 22, 2025 at 9:44 PM Sergey Tatarintsev wrote: > > 22.01.2025 18:41, Shlok Kyal пишет: > > Also we still don't care about foreign partitions (as I wrote earlier > we should raise an ERROR for such publications). > I think dealing with this separately from the origin vs. partitioned ta

Re: create subscription with (origin = none, copy_data = on)

2025-01-22 Thread Sergey Tatarintsev
22.01.2025 18:41, Shlok Kyal пишет: On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: On Tuesday, January 21, 2025 1:31 AM vignesh C wrote: Hi, On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: Attached patch has the fix for thi

Re: create subscription with (origin = none, copy_data = on)

2025-01-22 Thread Shlok Kyal
On Wed, 22 Jan 2025 at 09:00, Zhijie Hou (Fujitsu) wrote: > > On Tuesday, January 21, 2025 1:31 AM vignesh C wrote: > > Hi, > > > > > On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: > > > > > > On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: > > > > > > > > Attached patch has the fix for thi

RE: create subscription with (origin = none, copy_data = on)

2025-01-21 Thread Zhijie Hou (Fujitsu)
On Tuesday, January 21, 2025 1:31 AM vignesh C wrote: Hi, > > On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: > > > > On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: > > > > > > Attached patch has the fix for this issue which includes the > > > partition tables also for the publication now

Re: create subscription with (origin = none, copy_data = on)

2025-01-20 Thread vignesh C
On Mon, 20 Jan 2025 at 17:31, Amit Kapila wrote: > > On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: > > > > Attached patch has the fix for this issue which includes the partition > > tables also for the publication now and throws a warning > > appropriately. > > > > The corresponding query (se

Re: create subscription with (origin = none, copy_data = on)

2025-01-20 Thread vignesh C
On Sat, 18 Jan 2025 at 14:29, Sergey Tatarintsev wrote: > > I think we must take into account whole inheritance tree of partitioned table. > > For example: > > node_A: > CREATE TABLE t(id int); > CREATE PUBLICATION pub_b FOR TABLE t; > > node_A: > CREATE TABLE t(id int) PARTITION BY RANGE(id); > C

Re: create subscription with (origin = none, copy_data = on)

2025-01-20 Thread Amit Kapila
On Sat, Jan 18, 2025 at 10:31 AM vignesh C wrote: > > Attached patch has the fix for this issue which includes the partition > tables also for the publication now and throws a warning > appropriately. > The corresponding query (see "To find which tables might potentially include non-local origins

Re: create subscription with (origin = none, copy_data = on)

2025-01-18 Thread Sergey Tatarintsev
18.01.2025 12:01, vignesh C пишет: On Fri, 17 Jan 2025 at 21:30, vignesh C wrote: On Fri, 17 Jan 2025 at 14:00, Sergey Tatarintsev wrote: Hi, hackers! I am looking at subscription creation command: CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = none, copy_data = on)

Re: create subscription with (origin = none, copy_data = on)

2025-01-17 Thread vignesh C
On Fri, 17 Jan 2025 at 21:30, vignesh C wrote: > > On Fri, 17 Jan 2025 at 14:00, Sergey Tatarintsev > wrote: > > > > Hi, hackers! > > > > I am looking at subscription creation command: > > > > CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = > > none, copy_data = on); > > >

Re: create subscription with (origin = none, copy_data = on)

2025-01-17 Thread Sergey Tatarintsev
17.01.2025 23:00, vignesh C пишет: On Fri, 17 Jan 2025 at 14:00, Sergey Tatarintsev wrote: Hi, hackers! I am looking at subscription creation command: CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = none, copy_data = on); For now we log a warning if the publisher ha

Re: create subscription with (origin = none, copy_data = on)

2025-01-17 Thread vignesh C
On Fri, 17 Jan 2025 at 14:00, Sergey Tatarintsev wrote: > > Hi, hackers! > > I am looking at subscription creation command: > > CREATE SUBSCRIPTION sub CONNECTION '...' PUBLICATION pub WITH (origin = > none, copy_data = on); > > For now we log a warning if the publisher has subscribed to the same