On Wed, 14 Oct 2020 at 21:05, David Rowley wrote:
> I've attached the patch I ended up with. I plan on pushing this in the
> next few days.
Pushed.
David
On Mon, 28 Sep 2020 at 13:47, Hou, Zhijie wrote:
> Thanks for your response, combined them as a single patchset now.
I had a look over the three patches. All the changes look fine.
Thanks for working on it.
After a bit of grep work, I found about 6 times more calls that could
be improved. Thes
> Good point. There's another one:
> $ git grep -E 'appendStringInfoString.*".{,1}");'
> src/backend/utils/adt/ruleutils.c: appendStringInfoString(buf, "(");
> I noticed you added a similar thread here.
> https://commitfest.postgresql.org/30/
> I think this one could be combined as a singl
Hi
I made a slight update to the patch
> > > I found some more places that should use appendPQExrBufferStr instead
> > of appendPQExpBuffer.
> > >
> > > Here is the patch.
> >
> > Seems like a good idea. Please add it to the next commitfest.
>
> Thanks, added it to the next commitfest.
> https:
> On Tue, 22 Sep 2020 at 17:00, Hou, Zhijie wrote:
> > I found some more places that should use appendPQExrBufferStr instead
> of appendPQExpBuffer.
> >
> > Here is the patch.
>
> Seems like a good idea. Please add it to the next commitfest.
Thanks, added it to the next commitfest.
https://comm
On Tue, 22 Sep 2020 at 17:00, Hou, Zhijie wrote:
> I found some more places that should use appendPQExrBufferStr instead of
> appendPQExpBuffer.
>
> Here is the patch.
Seems like a good idea. Please add it to the next commitfest.
David
