Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-02-17 Thread Fujii Masao
On 2022/02/15 8:52, r.takahash...@fujitsu.com wrote: Hi Fujii san, Thank you for updating the patch. I have no additional comments. Thanks for the review! Pushed. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION

RE: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-02-14 Thread r.takahash...@fujitsu.com
Hi Fujii san, Thank you for updating the patch. I have no additional comments. Regards, Ryohei Takahashi

Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-02-10 Thread Fujii Masao
On 2022/02/09 9:19, r.takahash...@fujitsu.com wrote: Hi, Thank you for updating the patch. I agree with the documentation and program. How about adding the test for %c (Session ID)? (Adding the test for %C (cluster_name) seems difficult.) Ok, I added the tests for %c and %C escape sequence

Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-02-08 Thread Kyotaro Horiguchi
Sorry for missing this. At Thu, 27 Jan 2022 19:26:39 +0900, Fujii Masao wrote in > > On 2022/01/27 17:10, Kyotaro Horiguchi wrote: > > I don't object to adding more meaningful replacements, but more escape > > sequence makes me anxious about the increased easiness of exceeding > > the size lim

RE: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-02-08 Thread r.takahash...@fujitsu.com
Hi, Thank you for updating the patch. I agree with the documentation and program. How about adding the test for %c (Session ID)? (Adding the test for %C (cluster_name) seems difficult.) Regards, Ryohei Takahashi

Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-02-07 Thread Fujii Masao
On 2022/01/28 14:07, r.takahash...@fujitsu.com wrote: I think %c of log_line_prefix (Session ID) is also useful for postgres_fdw.application_name. Therefore, how about adding both %c (Session ID) and %C (cluster_name)? +1 Attached is the updated version of the patch. It adds those escape se

Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-01-28 Thread Robert Haas
On Thu, Jan 27, 2022 at 3:10 AM Kyotaro Horiguchi wrote: > Is the reason for 'C' in upper-case to avoid possible conflict with > 'c' of log_line_prefix? I'm not sure that preventive measure is worth > doing. Looking the escape-sequence spec alone, it seems to me rather > strange that an upper-ca

RE: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-01-27 Thread r.takahash...@fujitsu.com
Hi, Thank you for developing this feature. I think adding escape sequence for cluster_name is useful too. > Is the reason for 'C' in upper-case to avoid possible conflict with > 'c' of log_line_prefix? I'm not sure that preventive measure is worth > doing. Looking the escape-sequence spec alon

Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-01-27 Thread Fujii Masao
On 2022/01/27 17:10, Kyotaro Horiguchi wrote: At Tue, 25 Jan 2022 16:02:39 +0900, Fujii Masao wrote in Hi, Commit 6e0cb3dec1 allowed postgres_fdw.application_name to include escape sequences %a (application name), %d (database name), %u (user name) and %p (pid). In addition to them, I'd li

Re: Support escape sequence for cluster_name in postgres_fdw.application_name

2022-01-27 Thread Kyotaro Horiguchi
At Tue, 25 Jan 2022 16:02:39 +0900, Fujii Masao wrote in > Hi, > > Commit 6e0cb3dec1 allowed postgres_fdw.application_name to include > escape sequences %a (application name), %d (database name), %u (user > name) and %p (pid). In addition to them, I'd like to support the > escape sequence (e.g.