RE: Some codes refer slot()->{'slot_name'} but it is not defined

2025-04-05 Thread Hayato Kuroda (Fujitsu)
Dear Fujii-san, > I think this fix should be backpatched to all supported versions. > Since the issue you found and the one I found seem different, > I'd prefer committing them separately. I have no objections. > If that works for you, > here are the commit log messages I'm considering. LGTM, t

RE: Some codes refer slot()->{'slot_name'} but it is not defined

2025-04-04 Thread Hayato Kuroda (Fujitsu)
Dear Fujii-san, > -is($node_primary->slot('dropme_slot')->{'slot_name'}, > - undef, 'logical slot was actually dropped on standby'); > +is($node_primary->slot('dropme_slot')->{'plugin'}, > + '', 'logical slot was actually dropped on standby'); > > This seems like a separate issue from wha

RE: Some codes refer slot()->{'slot_name'} but it is not defined

2025-04-03 Thread Hayato Kuroda (Fujitsu)
Dear Fujii-san, > I've pushed the patches. Thanks! This is a closing post. I confirmed at least one BF animal for each version have been run and said OK. IIUC there are no threads to be forked. Thanks for pushing! Best regards, Hayato Kuroda FUJITSU LIMITED

Re: Some codes refer slot()->{'slot_name'} but it is not defined

2025-04-03 Thread Fujii Masao
On 2025/04/04 12:06, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, I think this fix should be backpatched to all supported versions. Since the issue you found and the one I found seem different, I'd prefer committing them separately. I have no objections. I've pushed the patches. Thanks

Re: Some codes refer slot()->{'slot_name'} but it is not defined

2025-04-03 Thread Fujii Masao
On 2025/04/03 21:23, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, -is($node_primary->slot('dropme_slot')->{'slot_name'}, - undef, 'logical slot was actually dropped on standby'); +is($node_primary->slot('dropme_slot')->{'plugin'}, + '', 'logical slot was actually dropped on sta

Re: Some codes refer slot()->{'slot_name'} but it is not defined

2025-04-03 Thread Fujii Masao
On 2025/04/03 12:15, Hayato Kuroda (Fujitsu) wrote: Dear hackers, Cluster.pm defines a function slot()which requires a slot_name as a key and returns attributes of the given slot, as a hash-ref. ISTM, the hash does not contain 'slot_name'. However, I found that some codes access it by using