Re: Performing partition pruning using row value

2021-04-08 Thread David Steele
On 2/16/21 9:07 AM, Anastasia Lubennikova wrote: On 21.07.2020 11:24, kato-...@fujitsu.com wrote: So, after looking at these functions and modifying this patch, I would like to add this patch to the next I updated this patch and registered for the next CF . https://commitfest.postgresql.org/29

Re: Performing partition pruning using row value

2021-02-16 Thread Anastasia Lubennikova
On 21.07.2020 11:24, kato-...@fujitsu.com wrote: So, after looking at these functions and modifying this patch, I would like to add this patch to the next I updated this patch and registered for the next CF . https://commitfest.postgresql.org/29/2654/ regards, sho kato Thank you for working

Re: Performing partition pruning using row value

2020-08-19 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I have performed testing of the patch with row comparison partiti

RE: Performing partition pruning using row value

2020-07-21 Thread kato-...@fujitsu.com
>So, after looking at these functions and modifying this patch, I would like to >add this patch to the next I updated this patch and registered for the next CF . https://commitfest.postgresql.org/29/2654/ regards, sho kato pruning-with-row-wise-comparison-v2.patch Description: pruning-with-r

RE: Performing partition pruning using row value

2020-07-09 Thread kato-...@fujitsu.com
Amit-san Friday, July 10, 2020 10:00 AM, Amit Langote wrote: >Speaking of which, I hope that Kato-san has looked at functions >match_rowcompare_to_indexcol(), expand_indexqual_rowcompare(), etc. in >indxpath.c as starting points >for the code to match RowCompares to partition >keys. Hmm, I did

Re: Performing partition pruning using row value

2020-07-09 Thread Amit Langote
On Fri, Jul 10, 2020 at 9:35 AM Etsuro Fujita wrote: > On Thu, Jul 9, 2020 at 7:57 PM Fujii Masao > wrote: > > On 2020/07/09 19:45, Etsuro Fujita wrote: > > > Please add the patch to the next CF so that it does not get lost. > > > > Is this a bug rather than new feature? > > I think it's a limit

Re: Performing partition pruning using row value

2020-07-09 Thread Etsuro Fujita
Fujii-san, On Thu, Jul 9, 2020 at 7:57 PM Fujii Masao wrote: > On 2020/07/09 19:45, Etsuro Fujita wrote: > > Please add the patch to the next CF so that it does not get lost. > > Is this a bug rather than new feature? I think it's a limitation rather than a bug that partition pruning doesn't sup

Re: Performing partition pruning using row value

2020-07-09 Thread Fujii Masao
On 2020/07/09 19:45, Etsuro Fujita wrote: Kato-san, On Thu, Jul 9, 2020 at 5:43 PM kato-...@fujitsu.com wrote: I made a patch that enable partition pruning using row-wise comparison. Please review and comment on this patch. Thanks for the patch! Please add the patch to the next CF so t

Re: Performing partition pruning using row value

2020-07-09 Thread Etsuro Fujita
Kato-san, On Thu, Jul 9, 2020 at 5:43 PM kato-...@fujitsu.com wrote: > I made a patch that enable partition pruning using row-wise comparison. > Please review and comment on this patch. Please add the patch to the next CF so that it does not get lost. Thanks! Best regards, Etsuro Fujita

RE: Performing partition pruning using row value

2020-07-09 Thread kato-...@fujitsu.com
c: PostgreSQL-development > Subject: RE: Performing partition pruning using row value > > Fujita san > > On Tuesday, July 7, 2020 6:31 PM Etsuro Fujita > wrote: > > Just to be clear, the condition (c1, c2) < (99, 99) is not equivalent > > to the condition c1 < 99 and

RE: Performing partition pruning using row value

2020-07-07 Thread kato-...@fujitsu.com
-Original Message- > From: Fujii Masao > Sent: Wednesday, July 8, 2020 3:20 PM > To: Kato, Sho/加藤 翔 ; 'Amit Langote' > > Cc: Etsuro Fujita ; PostgreSQL-development > > Subject: Re: Performing partition pruning using row value > > > > On 2020/07

Re: Performing partition pruning using row value

2020-07-07 Thread Fujii Masao
On 2020/07/08 13:25, kato-...@fujitsu.com wrote: Amit-san On Wednesday, July 8, 2020 11:53 AM, Amit Langote : I think the only reason that this is not supported is that I hadn't tested such a query when developing partition pruning, nor did anyone else suggest doing so. :) Seems we can do

RE: Performing partition pruning using row value

2020-07-07 Thread kato-...@fujitsu.com
ed to hear this reason. Regards, Sho kato > -Original Message- > From: Amit Langote > Sent: Wednesday, July 8, 2020 11:53 AM > To: Kato, Sho/加藤 翔 > Cc: Etsuro Fujita ; PostgreSQL-development > > Subject: Re: Performing partition pruning using row value > > Ka

Re: Performing partition pruning using row value

2020-07-07 Thread Amit Langote
Kato-san, On Wed, Jul 8, 2020 at 10:32 AM kato-...@fujitsu.com wrote: > On Tuesday, July 7, 2020 6:31 PM Etsuro Fujita > wrote: > > Just to be clear, the condition (c1, c2) < (99, 99) is not equivalent to the > > condition c1 < 99 and c2 < 99 (see the documentation note in [1]). > > Thanks for

RE: Performing partition pruning using row value

2020-07-07 Thread kato-...@fujitsu.com
POC that allows row-wise comparison with partition-pruning. Regards, sho kato > -Original Message- > From: Etsuro Fujita > Sent: Tuesday, July 7, 2020 6:31 PM > To: Kato, Sho/加藤 翔 > Cc: PostgreSQL-development > Subject: Re: Performing partition pruning using row val

Re: Performing partition pruning using row value

2020-07-07 Thread Etsuro Fujita
Kato-san, On Mon, Jul 6, 2020 at 5:25 PM kato-...@fujitsu.com wrote: > I would like to ask about the conditions under which partition pruning is > performed. > In PostgreSQL 12, when I executed following SQL, partition pruning is not > performed. > > postgres=# explain select * from a where (c1