On Thu, Jan 12, 2023 at 12:33 PM shiy.f...@fujitsu.com
wrote:
>
> On Wed, Jan 11, 2023 2:40 PM Amit Kapila wrote:
> >
> > On Wed, Jan 11, 2023 at 10:07 AM Tom Lane wrote:
> > >
> > > Amit Kapila writes:
> > > >> On Mon, Jan 9, 2023 11:06 PM Tom Lane wrote:
> > > >>> We could just not fix it in
On Wed, Jan 11, 2023 2:40 PM Amit Kapila wrote:
>
> On Wed, Jan 11, 2023 at 10:07 AM Tom Lane wrote:
> >
> > Amit Kapila writes:
> > >> On Mon, Jan 9, 2023 11:06 PM Tom Lane wrote:
> > >>> We could just not fix it in the back branches. I'd argue that this is
> > >>> as much a definition chang
On Wed, Jan 11, 2023 at 10:07 AM Tom Lane wrote:
>
> Amit Kapila writes:
> >> On Mon, Jan 9, 2023 11:06 PM Tom Lane wrote:
> >>> We could just not fix it in the back branches. I'd argue that this is
> >>> as much a definition change as a bug fix, so it doesn't really feel
> >>> like something t
Amit Kapila writes:
>> On Mon, Jan 9, 2023 11:06 PM Tom Lane wrote:
>>> We could just not fix it in the back branches. I'd argue that this is
>>> as much a definition change as a bug fix, so it doesn't really feel
>>> like something to back-patch anyway.
> So, if we don't backpatch then it coul
On Tue, Jan 10, 2023 at 8:38 AM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Jan 9, 2023 11:06 PM Tom Lane wrote:
> >
> > Amit Kapila writes:
> > > On Mon, Jan 9, 2023 at 5:29 PM shiy.f...@fujitsu.com
> > > wrote:
> > >> I think one way to fix it is to modify pg_publication_tables query to
> > >>
On Mon, Jan 9, 2023 11:06 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > On Mon, Jan 9, 2023 at 5:29 PM shiy.f...@fujitsu.com
> > wrote:
> >> I think one way to fix it is to modify pg_publication_tables query to
> >> exclude
> >> generated columns. But in this way, we need to bump catalog vers
Amit Kapila writes:
> On Mon, Jan 9, 2023 at 5:29 PM shiy.f...@fujitsu.com
> wrote:
>> I think one way to fix it is to modify pg_publication_tables query to exclude
>> generated columns. But in this way, we need to bump catalog version when
>> fixing
>> it in back-branch. Another way is to modif
On Mon, Jan 9, 2023 at 5:29 PM shiy.f...@fujitsu.com
wrote:
>
> I noticed that there is a problem about system view pg_publication_tables when
> looking into [1]. The column "attnames" contains generated columns when no
> column list is specified, but generated columns shouldn't be included becaus
