RE: Documentation Edits for pg_createsubscriber

2025-03-11 Thread Hayato Kuroda (Fujitsu)
Dear David, > And they will see empty strings (or blanks or whatever the defaults are) for > everything except LSN, like they always do, and not realize or care that our > code > generated file actually contained lines for them. (I haven't actually > experimented > here though.) It is OK for me

Re: Documentation Edits for pg_createsubscriber

2025-03-10 Thread Peter Smith
On Tue, Mar 11, 2025 at 8:20 AM David G. Johnston wrote: > > Hi. > > With all the recent work on pg_createsubscriber I decided to take a look at > it, namely the documentation. > I agree this page needs some improvement. Thanks for taking up this task. > The 0001 patch is basically just fixing

Re: Documentation Edits for pg_createsubscriber

2025-03-10 Thread David G. Johnston
Thank you for the quick reply. On Mon, Mar 10, 2025 at 7:56 PM Hayato Kuroda (Fujitsu) < kuroda.hay...@fujitsu.com> wrote: > Dear David, > > > The main thing I noted is that our synopsis is simply wrong regarding the > > optionality of the --database option. I went with a fix that included > onl

RE: Documentation Edits for pg_createsubscriber

2025-03-10 Thread Hayato Kuroda (Fujitsu)
Dear David, > The main thing I noted is that our synopsis is simply wrong regarding the > optionality of the --database option. I went with a fix that included only > showing the two mandatory options and adding a paragraph to usage explaining > that --database exists and how to use it. Our exis