Re: [V2] Adding new CRC32C implementation for IBM S390X

2025-07-17 Thread John Naylor
On Fri, Jul 11, 2025 at 7:01 PM Eduard Stefes wrote: > > On Wed, 2025-07-09 at 13:53 +0700, John Naylor wrote: > > v3 still has direct-call and runtime-check paths. Let's keep only > > USE_S390X_CRC32C_WITH_RUNTIME_CHECK and discard the direct call > > configure checks. Once that's done I'll take

Re: [V2] Adding new CRC32C implementation for IBM S390X

2025-07-12 Thread Eduard Stefes
Hi, On Wed, 2025-07-09 at 13:53 +0700, John Naylor wrote: > v3 still has direct-call and runtime-check paths. Let's keep only > USE_S390X_CRC32C_WITH_RUNTIME_CHECK and discard the direct call > configure checks. Once that's done I'll take a closer look and test > as > well. The rest should be sma

Re: [V2] Adding new CRC32C implementation for IBM S390X

2025-07-08 Thread John Naylor
On Tue, Jul 8, 2025 at 6:46 PM Eduard Stefes wrote: > > Hi, > > here is V3 of the patch. Changes from V2: > > - removed IBM copyright > - removed GETAUXVAL check in favor of the already provided check > - moved runtime selection code from pg_crc32c_s390x_choose.c to > pg_crc32c_s390x.c and removed

Re: [V2] Adding new CRC32C implementation for IBM S390X

2025-07-08 Thread Eduard Stefes
Hi, here is V3 of the patch. Changes from V2: - removed IBM copyright - removed GETAUXVAL check in favor of the already provided check - moved runtime selection code from pg_crc32c_s390x_choose.c to pg_crc32c_s390x.c and removed _choose.c file - removed the config time compiler check and let the

RE: [V2] Adding new CRC32C implementation for IBM S390X

2025-07-02 Thread Eduard Stefes
Hi, On Wed, 2025-06-11 at 13:48 +0700, John Naylor wrote: > Hi Eduard, thanks for the update. Note, it's not necessary to change > the thread subject, and in fact I came very close to missing this > email entirely. Sorry for the confusion. > Secondly, I haven't seen a response about the copyr

Re: [V2] Adding new CRC32C implementation for IBM S390X

2025-06-10 Thread John Naylor
On Thu, Jun 5, 2025 at 2:15 PM Eduard Stefes wrote: > > Hi, > > So here is V2 of the crc32c_s390x patch. Changes from V1 are: Hi Eduard, thanks for the update. Note, it's not necessary to change the thread subject, and in fact I came very close to missing this email entirely. Secondly, I haven't