Re: [PATHC] Fix minor memory leak in pg_basebackup

2020-04-16 Thread Michael Paquier
On Thu, Apr 16, 2020 at 10:54:09AM +, Zhang, Jie wrote: > So much the better! Thanks for confirming. Fixed, then. -- Michael signature.asc Description: PGP signature

RE: [PATHC] Fix minor memory leak in pg_basebackup

2020-04-16 Thread Zhang, Jie
Hi Michael so much the better! -Original Message- From: Michael Paquier [mailto:mich...@paquier.xyz] Sent: Thursday, April 16, 2020 2:31 PM To: Zhang, Jie/张 杰 Cc: pgsql-hackers@lists.postgresql.org Subject: Re: [PATHC] Fix minor memory leak in pg_basebackup On Wed, Apr 15, 2020 at 10

Re: [PATHC] Fix minor memory leak in pg_basebackup

2020-04-15 Thread Michael Paquier
On Wed, Apr 15, 2020 at 10:06:52AM +, Zhang, Jie wrote: > In some cases , PGresult is not cleared. > > File: src\bin\pg_basebackup\streamutil.c > > bool > RetrieveWalSegSize(PGconn *conn) > { > PGresult *res; RetrieveWalSegSize() gets called only once at the beginning of pg_basebacku