On Tue, Aug 24, 2021 at 5:38 PM Amit Kapila wrote:
>
> On Tue, Aug 24, 2021 at 7:13 AM Masahiko Sawada wrote:
> >
> > On Tue, Aug 24, 2021 at 10:01 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Masahiko Sawada
> > > > Sent: Tuesday, Augu
On Tue, Aug 24, 2021 at 7:13 AM Masahiko Sawada wrote:
>
> On Tue, Aug 24, 2021 at 10:01 AM houzj.f...@fujitsu.com
> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Masahiko Sawada
> > > Sent: Tuesday, August 24, 2021 8:52 AM
> > >
> > > Thanks. The patch for HEAD looks good to m
On Tue, Aug 24, 2021 at 10:01 AM houzj.f...@fujitsu.com
wrote:
>
>
>
> > -Original Message-
> > From: Masahiko Sawada
> > Sent: Tuesday, August 24, 2021 8:52 AM
> >
> > Thanks. The patch for HEAD looks good to me. Regarding the patch for PG14, I
> > think we need to update the comment as
> -Original Message-
> From: Masahiko Sawada
> Sent: Tuesday, August 24, 2021 8:52 AM
>
> Thanks. The patch for HEAD looks good to me. Regarding the patch for PG14, I
> think we need to update the comment as well:
>
> @@ -987,7 +986,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, b
On Mon, Aug 23, 2021 at 11:05 PM houzj.f...@fujitsu.com
wrote:
>
> On Mon, Aug 23, 2021 8:01 PM Amit Kapila wrote:
> > On Mon, Aug 23, 2021 at 2:45 PM
> > houzj.f...@fujitsu.com wrote:
> > >
> > > On Mon, Aug 23, 2021 12:59 PM Amit Kapila wrote:
> > > >
> > > > On Sat, Aug 7, 2021 at 6:53 PM ho
On Mon, Aug 23, 2021 8:01 PM Amit Kapila wrote:
> On Mon, Aug 23, 2021 at 2:45 PM
> houzj.f...@fujitsu.com wrote:
> >
> > On Mon, Aug 23, 2021 12:59 PM Amit Kapila wrote:
> > >
> > > On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
> > > wrote:
> > > >
> > > > Personally, I also think it
On Mon, Aug 23, 2021 at 2:45 PM houzj.f...@fujitsu.com
wrote:
>
> On Mon, Aug 23, 2021 12:59 PM Amit Kapila wrote:
> >
> > On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Personally, I also think it will be better to make the behavior
> > > consistent.
> > > Attach
On Mon, Aug 23, 2021 12:59 PM Amit Kapila wrote:
>
> On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Personally, I also think it will be better to make the behavior consistent.
> > Attach the new version patch make both ADD and DROP behave the same as
> > SET PUBLICATION
On Mon, Aug 23, 2021 1:18 PM Masahiko Sawada wrote:
> On Mon, Aug 23, 2021 at 1:59 PM Amit Kapila
> wrote:
> >
> > On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Personally, I also think it will be better to make the behavior
> > > consistent.
> > > Attach the new
On Mon, Aug 23, 2021 at 1:59 PM Amit Kapila wrote:
>
> On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Personally, I also think it will be better to make the behavior consistent.
> > Attach the new version patch make both ADD and DROP behave the same as SET
> > PUBLICATION
On Wed, Aug 18, 2021 at 7:54 PM Peter Eisentraut
wrote:
>
> On 10.08.21 05:22, Amit Kapila wrote:
> > Yeah, unless we change design drastically we might not be able to do a
> > refresh for dropped publications, for add it is possible. It seems
> > most of the people responded on this thread that w
On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
wrote:
>
> Personally, I also think it will be better to make the behavior consistent.
> Attach the new version patch make both ADD and DROP behave the same as SET
> PUBLICATION
> which refresh all the publications.
>
I think we can have test
On 10.08.21 05:22, Amit Kapila wrote:
Yeah, unless we change design drastically we might not be able to do a
refresh for dropped publications, for add it is possible. It seems
most of the people responded on this thread that we can be consistent
in terms of refreshing for add/drop at this stage b
On Tue, Aug 10, 2021 at 8:05 AM Masahiko Sawada wrote:
>
> On Sat, Aug 7, 2021 at 2:36 PM Amit Kapila wrote:
> >
> > On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
> > >
> > > >
> > > > Hmm yes, it cannot cover all cases. I had somehow misunderstood that
> > > > the subscriber knows which relati
On Sat, Aug 7, 2021 at 2:36 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
> >
> > >
> > > Hmm yes, it cannot cover all cases. I had somehow misunderstood that
> > > the subscriber knows which relations are associated with which
> > > publications. Given that the subscri
On Monday, August 9, 2021 11:10 AM Amit Kapila wrote:
>
> On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Sat, Aug 7, 2021 1:36 PM Amit Kapila wrote:
> > > On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
> > >
> > > Do you mean to say that do it for both Add and Drop o
On Sat, Aug 7, 2021 at 6:53 PM houzj.f...@fujitsu.com
wrote:
>
> On Sat, Aug 7, 2021 1:36 PM Amit Kapila wrote:
> > On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
> >
> > Do you mean to say that do it for both Add and Drop or just for Drop?
> > Actually, doing it both will make the behavior cons
On Sat, Aug 7, 2021 1:36 PM Amit Kapila wrote:
> On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
> >
> > >
> > > Hmm yes, it cannot cover all cases. I had somehow misunderstood that
> > > the subscriber knows which relations are associated with which
> > > publications. Given that the subscriber d
> On Aug 7, 2021, at 1:35 PM, Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
>>
>>>
>>> Hmm yes, it cannot cover all cases. I had somehow misunderstood that
>>> the subscriber knows which relations are associated with which
>>> publications. Given that the subscriber d
On Fri, Aug 6, 2021 at 9:57 PM Japin Li wrote:
>
> >
> > Hmm yes, it cannot cover all cases. I had somehow misunderstood that
> > the subscriber knows which relations are associated with which
> > publications. Given that the subscriber doesn’t know which relations
> > are associated with which pu
On Fri, Aug 6, 2021 at 2:50 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 10:09 AM Amit Kapila wrote:
> >
> > On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada
> > wrote:
> > >
> >
> > But, isn't this happening because of your suggestion to compare the
> > current set of relations with relation
Hi,
Sorry for the late reply. Having read this thread, the problem is caused by
misunderstanding the AlterSubscription_refresh(). My apologies.
On Fri, 06 Aug 2021 at 14:12, Masahiko Sawada wrote:
> On Fri, Aug 6, 2021 at 1:39 PM Amit Kapila wrote:
>>
>> On Fri, Aug 6, 2021 at 5:09 AM Masa
On Fri, Aug 6, 2021 at 1:39 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada wrote:
> >
> > On Thu, Aug 5, 2021 at 11:40 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > > To summary, I think that what we want to do in DROP SUBSCRIPTION cases
> > > > is to
> > > > drop r
On Fri, Aug 6, 2021 at 10:09 AM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada wrote:
> >
>
> But, isn't this happening because of your suggestion to compare the
> current set of relations with relations from publications that doesn't
> need to be removed? Do we have better
On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada wrote:
>
> On Thu, Aug 5, 2021 at 11:40 PM houzj.f...@fujitsu.com
> wrote:
> >
> > > To summary, I think that what we want to do in DROP SUBSCRIPTION cases is
> > > to
> > > drop relations from pg_subscription_rel that are no longer included in
> >
On Thu, Aug 5, 2021 at 11:40 PM houzj.f...@fujitsu.com
wrote:
>
> On Thursday, August 5, 2021 1:09 PM Masahiko Sawada
> wrote
> > I've reviewed v2 patch. Here are some comments:
> >
> > + if (type == ALTER_SUBSCRIPTION_SET_PUBLICATION ||
> > + type == ALTER_SUBSCRIPTION_R
On Thursday, August 5, 2021 1:09 PM Masahiko Sawada
wrote
> I've reviewed v2 patch. Here are some comments:
>
> + if (type == ALTER_SUBSCRIPTION_SET_PUBLICATION ||
> + type == ALTER_SUBSCRIPTION_REFRESH)
> + drop_table = !bsearch(&relid, pubrel_local_oids,
>
On Thu, Aug 5, 2021 at 2:08 PM Masahiko Sawada wrote:
>
> On Wed, Aug 4, 2021 at 9:19 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Wednesday, August 4, 2021 7:00 PM Masahiko Sawada
> > wrote
> > > On Wed, Aug 4, 2021 at 5:06 PM houzj.f...@fujitsu.com
> > > wrote:
> > > >
> > > > On Wednesday
On Wed, Aug 4, 2021 at 9:19 PM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, August 4, 2021 7:00 PM Masahiko Sawada
> wrote
> > On Wed, Aug 4, 2021 at 5:06 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Wednesday, August 4, 2021 1:47 PM Masahiko Sawada
> > >
> > > >
> > > > I've not l
On Wednesday, August 4, 2021 7:00 PM Masahiko Sawada
wrote
> On Wed, Aug 4, 2021 at 5:06 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Wednesday, August 4, 2021 1:47 PM Masahiko Sawada
> > >
> > > I've not looked at the patch deeply yet but I think that the
> > > following one line change seem
On Wed, Aug 4, 2021 at 5:06 PM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, August 4, 2021 1:47 PM Masahiko Sawada
> > On Mon, Aug 2, 2021 at 10:52 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > >
> > > Hi hackers,
> > >
> > > When testing some other logical replication related patches, I fou
On Wednesday, August 4, 2021 1:47 PM Masahiko Sawada
> On Mon, Aug 2, 2021 at 10:52 PM houzj.f...@fujitsu.com
> wrote:
> >
> >
> > Hi hackers,
> >
> > When testing some other logical replication related patches, I found
> > two unexpected behaviours about ALTER SUBSCRIPTION ADD/DROP
> PUBLICATION
Hi,
On Mon, Aug 2, 2021 at 10:52 PM houzj.f...@fujitsu.com
wrote:
>
>
> Hi hackers,
>
> When testing some other logical replication related patches, I found two
> unexpected behaviours about ALTER SUBSCRIPTION ADD/DROP PUBLICATION.
>
> (1)
> when I execute the following sqls[1], the data of table
33 matches
Mail list logo