Re: Quoting issues with createdb

2020-02-26 Thread Michael Paquier
On Thu, Feb 27, 2020 at 12:00:11AM +0100, Daniel Gustafsson wrote: > Makes sense, it aligns it with other utils and passes all the tests. +1 on > the > fix. Thanks for the review. > I would've liked a negative test basically along the lines of your example > above. If we left a hole the size o

Re: Quoting issues with createdb

2020-02-26 Thread Daniel Gustafsson
> On 14 Feb 2020, at 05:10, Michael Paquier wrote: > createdb has a couple of issues with its quoting. For example take > that, which can be confusing: > $ createdb --lc-ctype="en_US.UTF-8';create table aa();select '1" popo > createdb: error: database creation failed: ERROR: CREATE DATABASE > c

Quoting issues with createdb

2020-02-13 Thread Michael Paquier
Hi all, createdb has a couple of issues with its quoting. For example take that, which can be confusing: $ createdb --lc-ctype="en_US.UTF-8';create table aa();select '1" popo createdb: error: database creation failed: ERROR: CREATE DATABASE cannot run inside a transaction block The root of the