> On 14 Sep 2023, at 09:56, Michael Paquier wrote:
> (I'm OK with your patch as well, FWIW.)
Thanks for looking, pushed.
--
Daniel Gustafsson
On Wed, Sep 13, 2023 at 02:02:47PM +0200, Daniel Gustafsson wrote:
> It might be worth concatenating the errmsg() while there since we typically
> don't linebreak errmsg strings anymore for greppability:
>
> - errmsg("could not write to log file %s "
> - "at offset %u, length %zu:
> On 13 Sep 2023, at 13:55, Peter Eisentraut wrote:
>
> On 13.09.23 13:48, Daniel Gustafsson wrote:
>> Looking at zqfugous5du4d...@paquier.xyz I noticed that we had a a few
>> instances
>> of filenames in userfacing log messages (ie not elog or DEBUGx etc) not being
>> quoted, where the vast maj
On 13.09.23 13:48, Daniel Gustafsson wrote:
Looking at zqfugous5du4d...@paquier.xyz I noticed that we had a a few instances
of filenames in userfacing log messages (ie not elog or DEBUGx etc) not being
quoted, where the vast majority are quoted like \"%s\". Any reason not to
quote them as per th
Looking at zqfugous5du4d...@paquier.xyz I noticed that we had a a few instances
of filenames in userfacing log messages (ie not elog or DEBUGx etc) not being
quoted, where the vast majority are quoted like \"%s\". Any reason not to
quote them as per the attached to be consistent across all log mes
