Re: Question about commit 11cf92f6e2e13c0a6e3f98be3e629e6bd90b74d5

2019-03-05 Thread Robert Haas
On Tue, Mar 5, 2019 at 3:00 AM Etsuro Fujita wrote: > apply_projection_to_path() not only jams the given tlist into the > existing path but updates its tlist eval costs appropriately except for > the cases of Gather and GatherMerge: I had forgotten that detail, but I don't think it changes the ba

Re: Question about commit 11cf92f6e2e13c0a6e3f98be3e629e6bd90b74d5

2019-03-05 Thread Etsuro Fujita
(2019/03/02 1:10), Robert Haas wrote: On Fri, Mar 1, 2019 at 5:47 AM Etsuro Fujita wrote: Robert, I CCed you because you are the author of that commit. Before that commit ("Rewrite the code that applies scan/join targets to paths."), apply_scanjoin_target_to_paths() had a boolean parameter na

Re: Question about commit 11cf92f6e2e13c0a6e3f98be3e629e6bd90b74d5

2019-03-01 Thread Robert Haas
On Fri, Mar 1, 2019 at 5:47 AM Etsuro Fujita wrote: > Robert, I CCed you because you are the author of that commit. Before > that commit ("Rewrite the code that applies scan/join targets to > paths."), apply_scanjoin_target_to_paths() had a boolean parameter named > modify_in_place, and used appl

Question about commit 11cf92f6e2e13c0a6e3f98be3e629e6bd90b74d5

2019-03-01 Thread Etsuro Fujita
Hi, Robert, I CCed you because you are the author of that commit. Before that commit ("Rewrite the code that applies scan/join targets to paths."), apply_scanjoin_target_to_paths() had a boolean parameter named modify_in_place, and used apply_projection_to_path(), not create_projection_path(), to