Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-15 Thread Amit Kapila
On Wed, Jan 15, 2025 at 4:57 PM Amit Kapila wrote: > > LGTM. I'll push this tomorrow unless there are more comments. I am > planning to push this to HEAD as this is an improvement in existing > docs and not any bug fix. > Pushed. -- With Regards, Amit Kapila.

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-15 Thread Amit Kapila
On Tue, Jan 14, 2025 at 7:11 PM Robert Treat wrote: > On Tue, Jan 14, 2025 at 1:24 AM Peter Smith wrote: > > On Tue, Jan 14, 2025 at 4:46 PM Robert Treat wrote: > > > > -- > > Tables with a replica identity defined as NOTHING, > > DEFAULT without a primary key, or USING > > INDEX with a drop

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-14 Thread Robert Treat
On Tue, Jan 14, 2025 at 1:24 AM Peter Smith wrote: > On Tue, Jan 14, 2025 at 4:46 PM Robert Treat wrote: > > On Mon, Jan 13, 2025 at 8:07 PM Peter Smith wrote: > > > On Tue, Jan 14, 2025 at 8:22 AM Robert Treat wrote: > > > > On Mon, Jan 13, 2025 at 3:55 AM Amit Kapila > > > > wrote: > > > >

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-13 Thread Peter Smith
On Tue, Jan 14, 2025 at 8:22 AM Robert Treat wrote: > > On Mon, Jan 13, 2025 at 3:55 AM Amit Kapila wrote: > > On Mon, Jan 13, 2025 at 10:22 AM Robert Treat wrote: > > > On Sun, Jan 12, 2025 at 11:00 PM Amit Kapila > > > wrote: > > > > On Sat, Jan 11, 2025 at 7:28 PM Robert Treat wrote: > > >

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-13 Thread Robert Treat
On Mon, Jan 13, 2025 at 3:55 AM Amit Kapila wrote: > On Mon, Jan 13, 2025 at 10:22 AM Robert Treat wrote: > > On Sun, Jan 12, 2025 at 11:00 PM Amit Kapila > > wrote: > > > On Sat, Jan 11, 2025 at 7:28 PM Robert Treat wrote: > > > +If a table with replica identity set to NOTHING > > > +

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-13 Thread Amit Kapila
On Mon, Jan 13, 2025 at 10:22 AM Robert Treat wrote: > > On Sun, Jan 12, 2025 at 11:00 PM Amit Kapila wrote: > > > > On Sat, Jan 11, 2025 at 7:28 PM Robert Treat wrote: > > > > > > Definitely couldn't hurt; Updated patch cleans that up a bit and > > > tweaks the link to alter table replica statu

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-12 Thread Robert Treat
On Sun, Jan 12, 2025 at 11:00 PM Amit Kapila wrote: > > On Sat, Jan 11, 2025 at 7:28 PM Robert Treat wrote: > > > > Definitely couldn't hurt; Updated patch cleans that up a bit and > > tweaks the link to alter table replica status. > > > > IIUC, we have changed following to clarify the REPLICA ID

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-12 Thread Amit Kapila
On Sat, Jan 11, 2025 at 7:28 PM Robert Treat wrote: > > Definitely couldn't hurt; Updated patch cleans that up a bit and > tweaks the link to alter table replica status. > IIUC, we have changed following to clarify the REPLICA IDENTITY usage: If a table without a replica identity is - added to

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-12 Thread Peter Smith
On Sun, Jan 12, 2025 at 12:58 AM Robert Treat wrote: > > On Thu, Jan 9, 2025 at 10:41 PM Peter Smith wrote: > > > > Hi Robert. > > > > The content and rendering of patch v2 LGTM. > > > > Should the word wrapping within the file > > doc/src/sgml/logical-replication.sgml be tidied up though? > > >

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-11 Thread Robert Treat
On Thu, Jan 9, 2025 at 10:41 PM Peter Smith wrote: > > Hi Robert. > > The content and rendering of patch v2 LGTM. > > Should the word wrapping within the file > doc/src/sgml/logical-replication.sgml be tidied up though? > Definitely couldn't hurt; Updated patch cleans that up a bit and tweaks the

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-09 Thread Peter Smith
Hi Robert. The content and rendering of patch v2 LGTM. Should the word wrapping within the file doc/src/sgml/logical-replication.sgml be tidied up though? == Kind Regards, Peter Smith. Fujitsu Australia

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-09 Thread Robert Treat
On Thu, Jan 9, 2025 at 2:46 AM Peter Smith wrote: > > On Sat, Jan 4, 2025 at 4:23 AM Robert Treat wrote: > > > > On Wed, Dec 18, 2024 at 5:56 AM Amit Kapila wrote: > > > > > > On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe > > > wrote: > > > > > > > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smit

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-08 Thread Peter Smith
On Sat, Jan 4, 2025 at 4:23 AM Robert Treat wrote: > > On Wed, Dec 18, 2024 at 5:56 AM Amit Kapila wrote: > > > > On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe > > wrote: > > > > > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > > > - how to set the replica identity. If a table wit

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2025-01-03 Thread Robert Treat
On Wed, Dec 18, 2024 at 5:56 AM Amit Kapila wrote: > > On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe wrote: > > > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > > - how to set the replica identity. If a table without a replica > > > identity is > > > + how to set the replica iden

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-12-18 Thread Amit Kapila
On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe wrote: > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > - how to set the replica identity. If a table without a replica identity > > is > > + how to set the replica identity. If a table without a replica identity > > + (or with repl

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-12-18 Thread Amit Kapila
On Thu, Feb 8, 2024 at 7:24 PM James Coleman wrote: > > On Thu, Feb 8, 2024 at 4:47 AM Ashutosh Bapat > wrote: > > > > On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe > > wrote: > > > > > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > > > - how to set the replica identity. If a tabl

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-12-17 Thread Peter Smith
On Wed, Dec 18, 2024 at 2:50 AM James Coleman wrote: > > On Mon, Dec 16, 2024 at 6:17 PM Peter Smith wrote: > > > > While revisiting some old threads, I found this one that seemed to > > reach a conclusion, but then it seemed nothing happened. > > > > After multiple suggestions AFAICT James prefe

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-12-17 Thread James Coleman
On Mon, Dec 16, 2024 at 6:17 PM Peter Smith wrote: > > While revisiting some old threads, I found this one that seemed to > reach a conclusion, but then it seemed nothing happened. > > After multiple suggestions AFAICT James preferred the docs [1] > modification suggested [2] by Laurenz. > > Shoul

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-12-16 Thread Peter Smith
While revisiting some old threads, I found this one that seemed to reach a conclusion, but then it seemed nothing happened. After multiple suggestions AFAICT James preferred the docs [1] modification suggested [2] by Laurenz. Should we make a CF entry for this with the status RfC, or was the whol

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-08 Thread James Coleman
On Thu, Feb 8, 2024 at 4:47 AM Ashutosh Bapat wrote: > > On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe wrote: > > > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > > - how to set the replica identity. If a table without a replica > > > identity is > > > + how to set the replica id

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-08 Thread James Coleman
On Wed, Feb 7, 2024 at 11:27 PM Laurenz Albe wrote: > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > - how to set the replica identity. If a table without a replica identity > > is > > + how to set the replica identity. If a table without a replica identity > > + (or with rep

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-08 Thread Ashutosh Bapat
On Thu, Feb 8, 2024 at 9:57 AM Laurenz Albe wrote: > > On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > > - how to set the replica identity. If a table without a replica identity > > is > > + how to set the replica identity. If a table without a replica identity > > + (or with repl

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread Laurenz Albe
On Thu, 2024-02-08 at 13:40 +1100, Peter Smith wrote: > - how to set the replica identity. If a table without a replica identity is > + how to set the replica identity. If a table without a replica identity > + (or with replica identity behavior the same as > NOTHING) is > added to a p

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread Peter Smith
On Thu, Feb 8, 2024 at 11:12 AM James Coleman wrote: > > On Wed, Feb 7, 2024 at 6:04 PM Peter Smith wrote: > > > > On Thu, Feb 8, 2024 at 9:04 AM James Coleman wrote: > > > > > > On Wed, Feb 7, 2024 at 3:22 PM Laurenz Albe > > > wrote: > > > > > > > > On Wed, 2024-02-07 at 15:12 -0500, James C

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread James Coleman
On Wed, Feb 7, 2024 at 6:04 PM Peter Smith wrote: > > On Thu, Feb 8, 2024 at 9:04 AM James Coleman wrote: > > > > On Wed, Feb 7, 2024 at 3:22 PM Laurenz Albe > > wrote: > > > > > > On Wed, 2024-02-07 at 15:12 -0500, James Coleman wrote: > > > > We recently noticed some behavior that seems reaso

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread Peter Smith
On Thu, Feb 8, 2024 at 9:04 AM James Coleman wrote: > > On Wed, Feb 7, 2024 at 3:22 PM Laurenz Albe wrote: > > > > On Wed, 2024-02-07 at 15:12 -0500, James Coleman wrote: > > > We recently noticed some behavior that seems reasonable but also > > > surprised our engineers based on the docs. > > >

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread James Coleman
On Wed, Feb 7, 2024 at 3:22 PM Laurenz Albe wrote: > > On Wed, 2024-02-07 at 15:12 -0500, James Coleman wrote: > > We recently noticed some behavior that seems reasonable but also > > surprised our engineers based on the docs. > > > > If we have this setup: > > create table items(i int); > > inser

Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread Laurenz Albe
On Wed, 2024-02-07 at 15:12 -0500, James Coleman wrote: > We recently noticed some behavior that seems reasonable but also > surprised our engineers based on the docs. > > If we have this setup: > create table items(i int); > insert into items(i) values (1); > create publication test_pub for all t

Question about behavior of deletes with REPLICA IDENTITY NOTHING

2024-02-07 Thread James Coleman
Hello, We recently noticed some behavior that seems reasonable but also surprised our engineers based on the docs. If we have this setup: create table items(i int); insert into items(i) values (1); create publication test_pub for all tables; Then when we: delete from items where i = 1; we get: